feat(sensors): enable logging both pressure sensors on the 8/96 #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
=======================================
Coverage 83.28% 83.28%
=======================================
Files 101 101
Lines 4063 4063
=======================================
Hits 3384 3384
Misses 679 679 |
pmoegenburg
reviewed
Mar 26, 2024
include/motor-control/core/stepper_motor/motor_interrupt_handler.hpp
Outdated
Show resolved
Hide resolved
ryanthecoder
force-pushed
the
EXEC-266-double-sensor-pressure-move
branch
from
6686bc9 to
191c971
Compare
…ne move and report both pressure sensors
ryanthecoder
force-pushed
the
EXEC-266-double-sensor-pressure-move
branch
from
30cc6e6 to
d1786f0
Compare
ryanthecoder
force-pushed
the
EXEC-266-double-sensor-pressure-move
branch
from
9e189d1 to
d611977
Compare
| @@ -638,12 +652,20 @@ class MotorInterruptHandler { | |||
| static_cast<uint32_t>(position_tracker >> 31)); | |||
| } | |||
| #ifdef USE_PRESSURE_MOVE | |||
| void send_to_pressure_sensor_queue( | |||
| void send_to_pressure_sensor_queue_rear( | |||
| can::messages::BindSensorOutputRequest& m) { | |||
| std::ignore = sensor_tasks::get_queues() | |||
| .pressure_sensor_queue_rear->try_write_isr(m); | |||
| // if (!success) {this->cancel_and_clear_moves();} | |||
There was a problem hiding this comment.
commented line here and 663
ryanthecoder
force-pushed
the
EXEC-266-double-sensor-pressure-move
branch
from
e5cb0f1 to
b704875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXEC-266