allow larger upload #325
Open
allow larger upload #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tornado upload handler fails for larger files. In my case a 350mb log couldn't get uploaded. Setting `connection.set_max_body_size` appropriately fixed the issue. This MR sets this to either expected size, 10% over content-length if not provided or at least 500mb.
Member
|
Just to clarify, increasing the limit here isn't enough? |
Author
|
Didn't see that one. That also works. want me to update the MR? I understand the limit on the web version, for local deployment it would be nice to have it larger. I was running into the issue when logging EKF estimations. |
Member
|
I prefer to keep the existing limit as storage isn't free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tornado upload handler fails for larger files. In my case a 350mb log couldn't get uploaded. Setting
connection.set_max_body_sizeappropriately fixed the issue.This MR sets this to either expected size, 10% over content-length if not provided or at least 500mb.