Skip to content

Conversation

@VeckoTheGecko
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko commented Nov 25, 2024

Fixes #1773

(easier to review by looking at commit diffs)

@VeckoTheGecko VeckoTheGecko force-pushed the v/private-buffer branch 2 times, most recently from 8857e76 to a30af00 Compare November 25, 2024 16:38
@VeckoTheGecko
Copy link
Contributor Author

Uhh. Looks like we have DaskFileBuffer.add_to_dimension_name_map_global() and DaskFileBuffer.add_to_dimension_name_map() which are flagged with [externally callable]

Marking as draft while I have a think

@VeckoTheGecko VeckoTheGecko marked this pull request as draft November 25, 2024 17:24
@VeckoTheGecko VeckoTheGecko removed the request for review from erikvansebille November 25, 2024 17:24
@erikvansebille
Copy link
Member

Not needed in v4

@VeckoTheGecko VeckoTheGecko deleted the v/private-buffer branch September 11, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Make filefieldbuffer.py private

3 participants