Skip to content

Fixes for the RK45 Kernel #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erikvansebille merged 6 commits into from
Nov 24, 2025
Merged

Fixes for the RK45 Kernel #2397

erikvansebille merged 6 commits into from
Nov 24, 2025

Conversation

@erikvansebille
Copy link
Member

@erikvansebille erikvansebille commented Nov 21, 2025 •
edited
Loading

As I was working on also testing #2378 for the AdvectionRK45 Kernel, I realised that there were a few major bugs in that Kernel. This PR fixes these

  1. The Kernel returned the wrong StatusCode (Success instead of Evaluate), which meant particles were not advected at all (fixed in 3db13dd)
  2. The updating of dt did not work for dt < 0 (fixed in e9d136a)

@erikvansebille
Fixing wrong return code in RK45 Kernel
3db13dd
@erikvansebille
Fixing backward time in RK45
e9d136a
@erikvansebille
Add next_dt in RK45
6a67411 
This is needed in case dt is signalled for increasing in the RK45 Kernel; otherwise the wrong dt gets added in the add_positionupdate_kernel
erikvansebille added a commit that referenced this pull request Nov 21, 2025
@erikvansebille
Testing different Advection Kernels
fc71177 
Note that AdvectionRK45 doesn't work (fix in #2397)
@erikvansebille erikvansebille mentioned this pull request Nov 21, 2025
Merged
1 task
@erikvansebille erikvansebille merged commit 4b73c68 into v4-dev Nov 24, 2025
11 checks passed
@erikvansebille erikvansebille deleted the fix_RK45 branch November 24, 2025 11:05
@github-project-automation github-project-automation bot moved this from Backlog to Done in Parcels development Nov 24, 2025
erikvansebille added a commit that referenced this pull request Nov 25, 2025
@erikvansebille
Adding next_dt variable to make RK45 work
18a4590 
Note that I originally added in it 6a67411 (as part of
#2397) but then reverted it in e15c46c because I thought it wasn't necessary.

Now, it turns out it _is_necessary to have this next_dt when dt is allowed to increase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VeckoTheGecko VeckoTheGecko VeckoTheGecko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Parcels development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erikvansebille @VeckoTheGecko