Add deserialisation (i.e., field validators) for minute fields #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied a test from 99955d7 as mentioned in #136.
The problem was that there was no deserialisation (i.e., "field validation" in pydantic terms) of the minutes to the timedelta objects (serialisation = model -> file, validation = file -> model). By default it treated the float as seconds.
Were there any other fields that are in minutes besides
ADCPConfig.period,CTDConfig.stationkeeping_time,ShipUnderwaterSTConfig.period, andDrifterConfig.lifetime@erikvansebille and @ammedd ?Careful when merging this into ship_spped_in_knots to make sure the new Drifter.period also gets a deserialisation method like included in this PR.fixed