refactor(pages): one InfoPage shell behind about, legal and contract pages - #388
Merged
Conversation
…pages Six standalone pages each carried the same back link, gradient title band, card frame and Last-updated footer, and the four prose pages repeated a section heading and body-copy pattern per section. components/layout/info-page.tsx holds InfoPage (back target, width, header extra, spacing, footer), InfoSection, Prose and TestnetNotice. The prose pages read as their sections now; the private-feeds page keeps its own richer section helpers and only swaps the frame; the contract viewer passes its stats row as header content. Copy is unchanged. The about page's data-testid the e2e suite reads is kept.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
components/layout/info-page.tsx:InfoPage(back link, gradient title band, card, optional header extra, section spacing, "Last updated" footer),InfoSection(title with optional icon),Prose(body copy),TestnetNotice(the amber legal-page box).Section/SubSection/callout helpers), privacy, terms, cookies, contract (wide column, stats row asheaderExtra).FeatureCard; the cookies page's two storage cards shareStorageCard/StorageEntry.about-topologytest id the e2e suite reads is preserved.Why not MDX: no MDX plugin is installed, and these pages carry icons, links, a computed contract id and a topology stamp, so a component shell was the smaller change.
Part of the anti-slop cleanup series (after #370–#387).
Test plan
npm run lint(zero warnings),tsc --noEmit,npm run test,npx knip,npm run buildall green locally🤖 Generated with Claude Code