Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #1

wants to merge 1 commit into from

Conversation

mattcieslak
Copy link
Contributor

No description provided.

Comment on lines +12 to +13
1. Some regions are so small that when they're mapped to a low-res BOLD/DWI volume they will disappear. Should we allow this?
In some cases they are from dividing a region into subcomponents. We could recombine them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what nilearn's behavior is? I assume it just returns NaNs for the missing regions. I'd be fine with NaNs if the region disappears or is entirely outside the brain mask, generally speaking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly worried about what this means for those interpreting the connectivity matrices without thinking too hard about it. A column of NaNs isn't a big deal software-wise, but if someone is doing network science stuff on these matrices it's a big deal to have a fully disconnected node. We also know that there should almost never be an actually disconnected node in the brains we'll be analyzing. We looked at this problem here and it still haunts me


1. Some regions are so small that when they're mapped to a low-res BOLD/DWI volume they will disappear. Should we allow this?
In some cases they are from dividing a region into subcomponents. We could recombine them.
2. Regions may overlap each other from different atlases. Which should have precedence?
Copy link
Member

@tsalo tsalo Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, qsiprep needs everything to be in the same atlas file, right? Because xcpd can just concatenate time series files if necessary, I think. Just saw the next bullet point 😆

If there are overlapping regions, we could use a 4D atlas file, and basically pretend it's a probabilistic segmentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mrtrix, DSI Studio, etc need a single 3D volume :(

Comment on lines +15 to +17
3. For DWI the regions need to be defined *all in the same image*. BOLD regions can be in different images and you can calculate
connectivity from their timeseries later. But this isn't possible for DWI. Therefore, we can't include Tian and dwi/CIT168 atlases
in the same image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the atlas image be 4D?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not for the DWI usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants