-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several warnings #364
Fix several warnings #364
Conversation
WARNING py.warnings:_warnings.py:37 WARNING: Passing `palette` without assigning `hue` is deprecated and will be removed in v0.14.0. Assign the `x` variable to `hue` and set `legend=False` for the same effect.
WARNING py.warnings:_warnings.py:37 WARNING: `rcond` parameter will change to the default of machine precision times ``max(M, N)`` where M and N are the input matrix dimensions. To use the future default and silence this warning we advise to pass `rcond=None`, to keep using the old, explicitly pass `rcond=-1`.
This change will raise an error in Nilearn 0.15, but that will make it easier to detect and fix. WARNING py.warnings:_warnings.py:37 WARNING: Applying "mask_img" before signal extraction may result in empty region signals in the output. These are currently kept. Starting from version 0.13, the default behavior will be changed to remove them by setting "keep_masked_labels=False". "keep_masked_labels" parameter will be removed in version 0.15.
/src/aslprep/aslprep/tests/test_cli.py:7: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html from pkg_resources import resource_filename as pkgrf
Co-authored-by: Chris Markiewicz <[email protected]>
|
||
# NOTE: Modified for aslprep's purposes | ||
aslprep_spec = loads(Path(pkgrf("aslprep", "data/aslprep_bids_config.json")).read_text()) | ||
aslprep_spec = loads(load_data.readable("aslprep_bids_config.json").read_text()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I would pretty much only use readable()
in the form load_data.readable(...).read_<text|bytes>()
, as otherwise you need to check that whoever you're passing it to is only going to use read_text()
or read_bytes()
.
Co-authored-by: Chris Markiewicz <[email protected]>
https://www.nipreps.org/niworkflows/master/api/niworkflows.data.html If you add |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 78.81% 79.09% +0.28%
==========================================
Files 39 39
Lines 4149 4148 -1
Branches 600 600
==========================================
+ Hits 3270 3281 +11
+ Misses 685 673 -12
Partials 194 194 ☔ View full report in Codecov by Sentry. |
Closes none, but works on #344.
Changes proposed in this pull request
pkg_resources
withaslprep.data.load
.rcond
tonumpy.linalg.lstsq
calls.hue
in seaborn calls.keep_masked_labels
toTrue
inNiftiLabelsMasker
calls.