Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change participant-label to participant_label #185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yibeichan
Copy link
Collaborator

Hi this is related to #184
i checked that most BIDS Apps here (https://bids-website.readthedocs.io/en/latest/tools/bids-apps.html) uses --participant_label. for those which use --participant-label (e.g., fmriprep) also support --participant_label. so maybe it's better for us to use --participant_label

@tsalo
Copy link
Member

tsalo commented Feb 19, 2025

Hm... fMRIPrep mostly only supports dashes in its CLI parameters, so --participant_label is a bit of a one-off. With QSIPrep and QSIRecon (and probably XCP-D in the future) we only support --participant-label. so this might be something we need to configure on an app-by-app basis. @mattcieslak @tientong98 WDYT?

@mattcieslak
Copy link
Collaborator

yes, we'll have to configure it somehow. Maybe in the yaml?

@yibeichan
Copy link
Collaborator Author

we can either specify it if-else for certain bids-apps in the code, or add --participant_label or --participant-label specification somewhere in yaml?

@satra
Copy link
Collaborator

satra commented Feb 19, 2025

it's called --subject-label and only includes ids not sub- : https://bids-standard.github.io/execution-spec/inputs.html#reserved-arguments

i think we need a bids app validator for its input specs. many of those apps were created during a sprint and never updated afterwards. it may be useful to bring this up to the bids spec folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants