Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix None object appearing in config with anat-only QSIPrep inputs. #208

Closed
wants to merge 3 commits into from

Conversation

smeisler
Copy link
Contributor

@smeisler smeisler commented Feb 4, 2025

Closes none but issue brought up in https://neurostars.org/t/qsirecon-dsi-studio-autotrack/31657

Changes proposed in this pull request

When iterating through input DWIs and anatomicals, do not input a None for lack of anatomicals.

@tsalo
Copy link
Member

tsalo commented Feb 4, 2025

I don't think the Config object will handle the updated format. I'd recommend modifying config.py's handling of processing_list to allow None objects instead.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 48.74%. Comparing base (4f7dbde) to head (ee22e2d).

Files with missing lines Patch % Lines
qsirecon/cli/parser.py 36.36% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   48.75%   48.74%   -0.01%     
==========================================
  Files          56       56              
  Lines        7423     7424       +1     
  Branches     1015     1015              
==========================================
  Hits         3619     3619              
- Misses       3586     3587       +1     
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member

tsalo commented Feb 4, 2025

We should probably have a test that ignores the anatomical data.

@smeisler smeisler closed this Feb 4, 2025
@smeisler smeisler deleted the fix/anat_only_config branch February 4, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants