Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to vectorize connectivity matrices #1308

Closed
wants to merge 9 commits into from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Oct 29, 2024

Changes proposed in this pull request

Documentation that should be reviewed

@tsalo tsalo added enhancement New feature or request breaking-change PRs that change results or interfaces. labels Oct 29, 2024
@tsalo
Copy link
Member Author

tsalo commented Oct 29, 2024

Converting to a draft because this isn't high priority right now.

@tsalo tsalo marked this pull request as draft October 29, 2024 20:23
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 35 lines in your changes missing coverage. Please review.

Project coverage is 78.61%. Comparing base (9275de8) to head (0a0fe0f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
xcp_d/interfaces/connectivity.py 37.50% 32 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1308      +/-   ##
==========================================
- Coverage   78.90%   78.61%   -0.29%     
==========================================
  Files          59       59              
  Lines        7381     7445      +64     
  Branches      956      962       +6     
==========================================
+ Hits         5824     5853      +29     
- Misses       1266     1298      +32     
- Partials      291      294       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant