Ported PhotonUtils into Python #1739
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
reviewed
Jan 19, 2025
|
|
||
| @staticmethod | ||
| def estimateFieldToRobotAprilTag(cameraToTarget : Transform3d, fieldRelativeTagPose : Pose3d, cameraToRobot : Transform3d): | ||
| return fieldRelativeTagPose.__add__(cameraToTarget.inverse()).__add__(cameraToRobot) |
There was a problem hiding this comment.
calling add feels wrong - why doesn't + work
There was a problem hiding this comment.
I think this has been fixed, let me know if otherwise.
photon-lib/py/buildAndTest.sh
Outdated
|
|
||
| # Build wheel | ||
| python3 setup.py bdist_wheel | ||
| python setup.py bdist_wheel |
There was a problem hiding this comment.
This should be resolved, reverted it back to python3.
…feat/1738_cdl_photonUtils2025
…ptacon/photonvision into feat/1738_cdl_photonUtils2025 pulling parent changes
…ptacon/photonvision into feat/1738_cdl_photonUtils2025
…ptacon/photonvision into feat/1738_cdl_photonUtils2025
…ptacon/photonvision into feat/1738_cdl_photonUtils2025
gerth2
reviewed
Jan 26, 2025
|
Can we add unit tests for all the new functions you've added as well? |
Yeah, sure go for it!(sorry for late response) |
I think Matt's intent was more asking if you would be able to do that. (Matt, correct me if I'm wrong) |
samfreund
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported the Java PhotonUtils into Python, and ported the PhotonUtils to the vision test file.
Fixes #1738