Set the initial capacity of ArrayLists where possible

[kcooney]

Description

This can reduce reallocations of the underlying arrays.

Meta

Merge checklist:

• Pull Request title is short, imperative summary of proposed changes
• The description documents the what and why
• If this PR changes behavior or adds a feature, user documentation is updated
• If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
• If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
• If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
• If this PR addresses a bug, a regression test for it is added

[samfreund]

I'd like to see some data or an argument for why this is necessary. Currently, the size of our array lists isn't really something that tends to be an issue, and it might be better to avoid the added complexity this brings for such a small beenfit.

[spacey-sooty]

In my mind its small added complexity for small added benefit, seems reasonable.

[mcm001]

Only if consistently applied across the codebase. I'd rather we stick to 100% lists without a preset size, unless test data shows that this makes a statistically significant difference on our target platforms.

[kcooney]

@mcm001 @samfreund I made this at the suggestion of @Gold856 (see this comment).
For most of the changes in this PR, I think the added complexity is extremely low. Agreed that the added benefit is hard to measure.

I'd rather we stick to 100% lists without a preset size

Personally I think the changes in #2079 were justified. As of Java 17 the initial capacity of an ArrayList is 10¹, so if the capacity was unset then if there were more than then queued results, PhotonCamera.getAllUnreadResults() would resize two arrays at least once each.

¹ In Java 17 ArrayList instances created via the default constructor share a common empty array; an array of size 10 would be allocated if a single element was inserted into an empty ArrayList.

[mcm001]

I'd still like to see some performance metrics if possible. If you see the ArrayList constructor on the hotpath on roborio or older Pi platforms, I'd be more inclined to merge.

[kcooney]

I'd still like to see some performance metrics if possible. If you see the ArrayList constructor on the hotpath on roborio or older Pi platforms, I'd be more inclined to merge.

Do you have pointers on how I would get those metrics?

[samfreund]

I'd still like to see some performance metrics if possible. If you see the ArrayList constructor on the hotpath on roborio or older Pi platforms, I'd be more inclined to merge.

Do you have pointers on how I would get those metrics?

Print out how long it takes for a pipeline with and without the changes?