Skip to content

Add pose filtering to pose estimation examples#2472

Open
witherrrr wants to merge 8 commits intoPhotonVision:mainfrom
witherrrr:add-pose-filtering-example
Open

Add pose filtering to pose estimation examples#2472
witherrrr wants to merge 8 commits intoPhotonVision:mainfrom
witherrrr:add-pose-filtering-example

Conversation

@witherrrr
Copy link
Copy Markdown

Description

Adds filtering of pose estimates to the example code for performing pose estimation with PhotonVision. This addresses a common pain point with incorrect PV poses causing issues downstream in the pose estimator by providing some example code to filter out common bad poses.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why, including events that led to this PR
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added
  • If this PR adds a dependency, the license has been checked for compatibility and steps taken to follow it

@witherrrr witherrrr requested a review from a team as a code owner May 6, 2026 03:23
Comment thread photonlib-cpp-examples/poseest/src/main/include/Vision.h Outdated
Comment thread photonlib-cpp-examples/poseest/src/main/include/Vision.h Outdated
@witherrrr witherrrr requested a review from spacey-sooty May 6, 2026 04:29
@samfreund
Copy link
Copy Markdown
Member

Broadly LGTM, waiting until examples are less borked so it can actually build and stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants