Store calibration units in mm#2480
Open
thatcomputerguy0101 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
frontend
thatcomputerguy0101
force-pushed
the
mm-calibration
branch
from
9ac98f3 to
6c37b9f
Compare
thatcomputerguy0101
force-pushed
the
mm-calibration
branch
from
2d6551c to
10dbee1
Compare
thatcomputerguy0101
force-pushed
the
mm-calibration
branch
from
58650d1 to
c319498
Compare
| break; | ||
|
|
||
| case CalibrationBoardTypes.Charuco: | ||
| // TODO: Dynamically generate ChArUco using opencv |
Contributor
Author
There was a problem hiding this comment.
I forgot I left this TODO in here. Dynamic ChArUco generation might be the topic of another PR though.
thatcomputerguy0101
changed the title
| @@ -110,32 +110,32 @@ watchEffect(() => { | |||
| uniqueVideoResolutionIndex.value = currentIndex; | |||
| }); | |||
| const dimensionUnit = ref<"in" | "mm">("in"); | |||
Contributor
Author
There was a problem hiding this comment.
Which unit do we want to be the default?
Contributor
There was a problem hiding this comment.
I only kept it as inches since that's the existing behaviour.
I reckon whatever the default is should match whatever's in the board PDF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extension of #2479 that also changes the backend to use millimeters instead of inches.
Meta
Merge checklist: