Add visual marker behaviors #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pac48
force-pushed
the
pr-add-visual-marker-behaviors
branch
from
fec0786 to
e79db51
Compare
Signed-off-by: Paul Gesel <[email protected]>
pac48
force-pushed
the
pr-add-visual-marker-behaviors
branch
from
e79db51 to
9127676
Compare
MikeWrock
reviewed
Feb 27, 2025
| transform_start = shared_resources_->transform_buffer_ptr->lookupTransform( | ||
| "world", start_pose_stamped.header.frame_id, tf2::TimePointZero); | ||
| transform_end = shared_resources_->transform_buffer_ptr->lookupTransform( | ||
| "world", start_pose_stamped.header.frame_id, tf2::TimePointZero); |
There was a problem hiding this comment.
Suggested change
| "world", start_pose_stamped.header.frame_id, tf2::TimePointZero); | |
| "world", end_pose_stamped.header.frame_id, tf2::TimePointZero); |
MikeWrock
reviewed
Feb 27, 2025
| { BT::InputPort<geometry_msgs::msg::PoseStamped>(kPortIDPose, "", "The text pose."), | ||
| BT::InputPort<std::string>(kPortIDMessage, "", "The text message to display."), | ||
| BT::InputPort<double>(kPortIDScale, 1.0, "The text scale."), | ||
| BT::InputPort<std::vector<double>>(kPortIDPositionXyz, { 0.0, 0.0, 0.0 }, |
There was a problem hiding this comment.
Why do we need to give position if that information is in the PoseStamped? If the intent is to just get the orientation, I say we pass in a quaternion and position vector instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our example objectives are not built due to memory issues. I created a new package just for visualization objectives needed by #167 that builds.