…#10797)

* Fix issues with unexpected date filter params for the process listing

* Add extra test to test the fully rendered version

…removed (#10607)

* Add event handlers to destroy records

* Trigger event from Assemblies

* Trigger event from Processes

* Trigger event from Conferences

* Running linters

* Add cleanup rake task

* Add release notes

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Check if modules are being installed

* Running linters

* More linting

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Change the participant initiatives editor toolbars type

* Fix the expectation in the initiative editor spec

* Add specs to ensure correct editor in complete and edit views

This used to cause an error.

* Refactor factories titles

* Cleanup factories syntax

* Add examples for enriched content in Search

* Refactor conference's program meetings regarding display of content

* Improve the meetings factories

* Improve Conferences module

Fixing accountability spec

Fixing meetings

Fix Proposal related specs

Fixing more failing specs

Fixing more specs

* Refactor initiatives factories

* Fix meeting specs

* Fix initiatives related issues

* Fix admin specs

* Fix meeting calendar

* Fixing more decidim-initiatives spec

* Fixing latest failed tests

* Run linter

* Fix flacky spec

* Apply code review recommendation

---------

Co-authored-by: Alexandru Emil Lupu <[email protected]>

* Add binstub for `bin/dev`

* Add instructions for `bin/dev` binstub

* Add controller concern

* Extract index method

* Refactor I18n scoping

* Extract filterable behavior

* Refactor Create and update actions

* Fix Failing specs from previous run

* Remove the destroy space commands

* Refactor Create and Update user commands

* Refactor the Update command

* Fix failing specs from last version

* Refactor the create User Role command

* Refactor create_role commands

* refactor collection method

* Further refactor. Breaking things

* Breaking even more things- remove the create commands

* Fixing Failing specs

* Fix failing specs

* Convert concern to controller

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update gems to next available patch level

* Fix failing spec

* Update gems to next available patch level

* Fix webpack version to <5.83.0

* Run bin/rake webpack and change < for ~ in package.json

…10865)

* Standardize initializer naming and add tests to ensure consistency

* Improve the engine initializers

* Fix the initializer name in the map examples after hook

* Fix the initializer names in documentation references

* Fix initializer name in the spec

* Fix remaining initializer names and add few more engine specs

* Ensure a dot after the engine name in the initializer name

* Remove redundancy from the initializer naming

* Fix the active filter for process groups

* Fetch the processes through scopes

* Add a spec to test if the end date is not set

* Convert SECURITY file from AsciiDoc to Markdown

If not it's not easily discoverable by some GitHub tooling, such as the
"Security overview" page:
https://github.com/decidim/decidim/security/policy

* Fix line length

* Add "Vulnerability disclosure policy" section

…#10766)

* Disable poorly formatted requires

* Split the dummy-resources in an engine

* Fixing broken namespaces

* Remove commented code

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Add translation string for URL error message

* Updated error message key for URL validator

* URL validator change I18n task update

* Viewing correct partners in Conferences edit

* Edit partners under conferences spacing patch

* Budget component set at zero in view

* Adding suggestion of Alex to patch

* Integrate the editor with the redesigned layout

* Add a general upload error message on non HTTP 200 responses

* Remove done item from the comment

* Fix async issue with the image upload handling

The image upload response handling was not always returning a
promise which caused inconsistent behavior across browsers.

* Normalize i18n

* Remove the quill list styling hacks

* Remove legacy quill styling classes from CSS

* Modify the iframe disabler tests to use new video embed markup

* Remove vendored legacy Quill extensions

* Remove the TipTap YouTube extension as it is not used

* Implement image resizer

* Add dialog extension and refactor image resizing

- In order to control the editor styling while the modal dialogs
  are open, add a new dialog extension that stores the dialog state
  for the editor itself
- Refactor the image extension to move the custom node view for
  image resizing to its own file

* Add activity outline for editor images and video embeds

* Move the other extensions to a similar folder structure

In order to maintain consistency for the structuring of the code,
move other extensions to a folder stucture after the image
extension required its own folder.

* Add support for user mentions and hashtags

* Fix checking if the src has changed

The `img` element's src can also get the hostname prepended to it
when the previous check would not work. Updated to check if the
actual node attribute has changed.

* Remove console logs

* Fix the editor system specs for image content after image resizer

As the generated editor HTML changed, the expectation also needs
to be changed.

* Fix editor hashtags suggestion list label rendering

* Fix mentions sorting strings (exclude the mention character)

* Conditionally add hashtag and mention extensions to the editor

In case the editor container contains the classes to indicate
these features are needed, only add those extensions in that
case.

* Do not attach tribute to the editor

The editor implements its own hashtags and mentions functionality
which is why we do not need to attach tribute to the editors.

* Remove tribute styling from the editor as it is not used

* Remove Quill global from the default eslint config

* Match design app packages

* Integrate character counter with the editor

* Fix the enabled/disabled editor toggle in conferences and meetings

In case the registrations are disabled, disable also the editors
in those views. Previously they were only enabled.

* Remove the last TODO item

* Rename editor modal to dialog for consistency

We are using the dialog concept in the redesign to control the
dialogs, so we want to use consistent naming also in the editor.

* Fix the form builder upload dialog selector attribute

* Add `allowfullscreen="true"` to the iframe embeds

* Add content migrator to migrate WYSIWYG content

This handles the changes in the WYSIWYG content formatting between
Quill.js and TipTap by converting the legacy format to the format
generated by the new TipTap editor.

* Fix sub-list margins

We do not want to add the paragraph margin in sub-lists.

* Allow content migration to be run on already migrated content

* Add methods to migrate the actual data + specs for them

* Add the WYSIWYG migration rake task

* Fix editor input height issues

The height was set on the whole container that also includes the
toolbar but it should be actually on the input area instead.

* Editor CSS in Tailwind

* Refactor decidim_editor to its own JS pack for CSS compatibility

In order to utilize the Tailwind CSS based editor CSS, we include
it in the JS and pack the editor as its own includable asset.

* Update JS override docs reference to the `editor.js`

* Add entrypoint for the editor CSS and include it in the head

* Remove the editor CSS include from the index.js

Because it is already included in the entrypoint.

* Integrate the indent extension with lists

* Remove the TODO after applying Tailwind to the editor CSS

* Add the `redesigned_` prefix to the editor CSS to avoid lint issue

* Do not include the legacy (removed) editor.scss

Remove the legacy editor.scss import from legacy design and
decidim-system.

* Fix the editor CSS custom properties/colors + suggestions properties

* Fix list integration with the indent extension

* Rewrite the indent extension to simplify its code

To better utilize the TipTap APIs instead of relying more on
ProseMirror, rewrite the indent extension to also consider the
Decidim specific functionality better, i.e. managing the
indentation through the toolbar.

* Add editor related release notes

* Fix the content migration registration task's description

* Fix button order in the input dialogs under redesigned layout

* Also display the suggestions on start and change innerText to textContent

* Change `innerText` to `textContent` to support jest tests

* Consider the toolbar styles for adding the editor features

We have `full` and `basic` toolbars that support different
features. Consider this when initiating the editor.

* Do not search hashtags if the query is less than 2 characters

* Add jest tests for the editor

* Fix accessibility violations with the editor and add labelledby

* Use the `uniqueId` helper also in the input dialog

* Fix empty target on the link element

* Add E2E system/capybara tests for the editor

* Add ID to the editor elements after the a11y/validation fixes

After making the validation fixes, the editor elements were no
longer targetable in the specs because of the missing ID.

* Fix the targeting of the editor elements in specs

* Fix new proposal specs after changes in the editor structure

* Fix the missing title elements for the video embed pasting

* Add test for hashtag with the Enter key

* Improvement on test helpers range selector, basic editor and refactor

* Add tests for the indent extension

* Add tests for the VideoEmbed extension

* Toggle the dialog state correctly for the image upload dialog

* Add tests for the link extension

* Improve the file related test helpers for the image extension tests

* Add tests for the image extension

* Add the Enter key test for the mention extension

* Remove commented code

* Add E2E tests for video embed and image toolbar controls

* Add E2E tests for pasting content

* Name the describe block correctly in the Image extension test

* Add tests for the image resizing

* Extend the image extension tests to cover the touch dragging

* Add E2E tests for image resizing and fix E2E tests image endpoints

* Add E2E tests for the legacy designed editor

* Add jest tests for editor with the legacy design

* Add width and height info to added images

* Fix width setting on first image load to the editor

* Fix onload image text issue

* Fix a bug in pasting image

* Add setTimeout to fix initial value issue in test

* Add tests for dimensions text

* Add system test for image dimensions info

* Fix linting error

* Fix js test fails

* Remove commented code

* Add code comments to describe some of the image node view oddities

* Fix the admin manages organization spec after adding image dimensions

* Add prose styling to the editor content

* Remove the customised CodeBlock extension and its markup

After applying the prose styling to the editor content, the custom
`code-block` class is no longer necessary on the code block
elements.

* Fix the image and video embed margins after applying prose styling

* Fix image resizer on touch screens and add accessibility labels

* Apply the image resizer changes to the admin manages org spec

* Fix initiating hashtags and mentions capability

The capability classes were checked against the wrong container.

* Parse and render hashtags and mentions correctly at the backend

Because Tiptap requires a specific format for the hashtags and
mentions, we convert them for the editor specifically and
translate them back to the GID references at the backend before
the content is saved to the database.

* Fix a sanitize helper bug when the list elements have line breaks

In case the list elements are prepended or appended with line
breaks, sanitizing HTML to text does not work correctly.

* Dispatch the emoji event on the correct element

Previously the element was not properly dispatched on the
contenteditable elements.

* Add emoji support for the editor

* Fix the emoji input contenteditable and editor integration

* Fix the color of the disabled emoji button

* Fix input emoji positioning with the content editable elements

* Fix hashtags on the participant side with WYSIWYG editor

* Handle the `rel` attribute on the links through LinkRenderer

In order to control when we add the necessary `rel` attributes
for the user entered links, we control this through the
LinkRenderer at the backend and leave these attributes out of the
original link elements.

* Fix the `rel` expectations in the Jest test for the editor

* Fix the system specs after the `rel` changes to the editor

* Mock `@pickmo/popup-picker` for the specs due to incompatibility

* Fix syntax issue with the Emoji extension

* Fix autolinking links within HTML content

In case the link was without the link tag in HTML content, it was
not autolinked properly.

* Fix rendered link expectations after unifying their attributes

* Fix redenred content expectations after changing linkrenderer behavior

* Fix link renderer spec after changes in the link href format

After the link is generated through the tag helper, some
characters are now escaped in the `href` attribute.

* Fix heading extension compatibility with hashtags extension

* Fix typo

* Remove console logs

* Move similar spec code to a shared context

* Remove commented spec

* Support mentions and emojis for the editor through form builder

* Add system specs for the editor hashtags and mentions

* add-image-button-fix/test

* Also test adding files in the redesign + small refactor for the spec

* Fix the user mentions spec in the editor E2E tests

* Add editor spec for selecting emojis

* Fix character counter bug with new paragraph breaks after reaching limit

* Add jest tests for the editor Emoji extension

* Add jest test for the editor Heading extension

* Fix image resizing on Firefox

* Do not use the MouseEvent class after adding the device information

* Fix the ordered list types/styling

* Fix the test name for the Heading extension test

* Fix the image resize specs after changes in the resizer

* Disable the link target control from participant facing editors

* Change the link control and dialog behavior slightly

- Take out the "Remove" button from the link dialog to make it
  consistent with the other dialogs
- Make the toolbar link control remove the existing link when an
  existing link is selected
- Allow double clicking an existing link to open the link edit
  dialog

* Simplify

* Update the minimum versions of Tiptap

* Allow editing and removing link from toolbar

- Re-allow editing the link from the toolbar link button
- Allow removing the link using the erase styles toolbar button

* Implement link bubble

* Fix a11y issue with `aria-expanded` attribute added by tippy.js

* Fix pasting bold list items with unbold sublist items from google docs

* Fix ordered list style for Google Docs

* Remove console.log

* Fix bug in the input dialog not toggling dialog mode off

When the dialog was closed through some other method than clicking
one of the dialog actions, it did not toggle the dialog mode off
properly.

* Rework the link bubble styles, prevent text overflow

* Remove unnecessary commented code

* Generalize the bubble menu implementation

Separate the specific functionality for the link bubble menu
and the rest of the bubble menu code in order to make the
component useful also for other possible use cases.

* Change the legacy dialog tests after changing input dialog JS

Trigger the `closed` event on the dialog element in order to make
the legacy dialog tests work with the changes.

* Move the override methods to the bottom of the class

* Remove `tippy.js` dependency in favor of custom implementation

Instead of introducing a new rather heavy dependency (for its
purpose) for managing the bubble menus, implement the
functionality ourselves.

* Refactoring: introduce decidim kit extension

- Move some of the initialization logic to the DecidimKit extension
- Move the upload dialog initialization to the image extension due
  to the refactoring effort
- Fix the jest tests for the image extension

* Name the extension correctly

* Move image extension options to the correct if clause

* Remove unnecessary commented code from the test

* Add keyboard shortcuts to change the ordered list type

Add keyboard shortcuts (`ALT`+`SHIFT`+`UP` and
`ALT`+`SHIFT`+`DOWN`) to navigate through the ordered list types.

* Name the test example correctly

* Add tests for the added keyboard shortcut for changing ordered list type

* Add tests for the clipboard pasted ordered lists

Test that some issues discovered during the acceptance testing are
properly handled by the editor. This relates to pasting ordered
lists with the `type` defined for them which defines the list item
styling (e.g. alphabetical lists and roman numeral lists).

* Add reference to the TipTap issue regarding character counter

* Modify the Google Docs expectation according to actual markup

When contnet is copied from Google Docs, the sub-lists are outside
of the list elements they are decendant of. Modify the pasted
content according to this.

* Add reference to the TipTap GitHub issue

* Add Jest test for the Google Docs formatted ordered list

* Add reference to the TipTap GitHub issue for bold content in lists

* Fix styling ordered lists with the `type` attribute

* Change the typed ordered list style definitions to Tailwind syntax

* Fix pasting lists from Office 365

* Add jest tests for the DecidimKit extension

* Add tests for the bold extension customization

* Correct the markup example in the comment

* Correct the extension imports in the jest tests

* Improve the code for processing Office 365 pasted content

* Fix pasting lists from desktop Word

* Lock sass-embedded to 1.57.1 due to a compile bug

* Remove unused code

* Use upload templates in the image extension jest test

Instead of creating the upload dialog element manually, use the
upload templates available in the fixtures.

* Do not add `null` values for the list `type` attribute

* Only add the `type` attribute to `<ol>` lists

* Test the single list item flat list copied from desktop Word

As the single items are a special case, test those as well. Also
to test that the bullet lists are correctly transformed to `<ul>`
elements.

* Fix external link indicators triggering within the editor in redesign

* Add tests for the link bubble menu

* Fix updating some input dialog values using ENTER

Submitting all input dialogs did not work using the ENTER key.
This makes the behavior consistent over all input dialogs.

* Fix flaky editor system specs regarding the bubble menu

* Fix rubocop violation in the editor spec

* Fix the disabled rubocop rule namespace

* Remove unnecessary if clause

* Fix form submit when resizing an image on certain forms

* Fix jest expectations after adding `type` to image resize controls

* Fix the expectation at the admin manages organization spec

After adding the `type="button"` to the image resize controls, the
expectation at the admin manages organization spec was incorrect.

* Enable new spelling checks (#10605)

* Switch away from Webpacker to Shakapacker  (#10389)

* patch the generator to use custom branch

* Remove Webpacker, Install Shakapacker

* Patch shakapacker decidim-core

* Update the rake task and base Js

* Update shakapacker npm package

* Update npm api

* Patch the workflows

* Fixing decidim-admin test suite

* Fixing decidim-core specs

* Fix decidim-dev specs

* Fixing decidim-core

* Fixing decidim-assemblies specs

* Fixing decidim-verifications specs

* Fixing decidim-consultations specs

* Fix more decidim-assemblies

* Fixing decidim-consultations

* Fix decidim-conferences

* Partially fixing decidim-initiatives

* Partially fixing participatory-processes

* Fixing decdim-generators

* Running linters

* Fixing more decidim-core specs

* Partially fix decidim-proposals

* Fix decidim-accountability specs

* Fix decidim-proposal cell

* Fix decidim-budgets specs

* Fix decidim-debates

* Fix decidim-templates

* Partially fix decidim-surveys

* Fix decidim-surveys

* Partially fix decidim-meetings

* Fix decidim-templates

* fix geocoding fields

* Fix more decidim-initiatives

* Fix more decidim-meetings specs

* Fix more decidim-proposals

* Fix more decidim-meetings

* Fix decidim-elections, decidim-votings (#10422)

* Fix decidim-elections, decidim-votings

* fix more decidim-elections

* Fixing more decidim-elections

* more fixes in decidim-elections

* Add release notes

* Lint RELEASE_NOTES.md

* Set custom webpacker.yml location

* Patch lighthouse workflow

* Remove unecessary content_fors

* Patch the webpacker config

* Make use of append_stylesheet_pack_tag

* Fixing the map elements

* patch the release notes

* Lint erb files

* Apply MR recommendations

* Patch rails cells to use the rails view context as a reference

* Replace javascript_snippets and stylesheet_snippets by append_assets

* Update to shakapacker 6.6.0

* Remove shakapacker override in generator

* Remove workflow patch

* Linters

* Fix generator

* Bugfix

* Revert commonmarker downgrade

* Apply review recomandations regarding procfile

* Apply review recommendations

* Lock both JS and Ruby shakapacker versions at 6.6.x to avoid breaking our pipelines

* Run the decidim:procfile:install rake task during application generation

* Chmod the bin/dev script correctly

* Change the default for WEBPACKER_RUNTIME_COMPILE to false

* Compile the assets automatically during tests if they haven't been compiled before

* Remove unnecessary lines from the map specs after the refactoring

* Lock both JS and Ruby shakapacker versions at 6.6.x to avoid breaking

* Preparing to merge to develop

* Adding development notes, as suggested

* Last batch of changes

* Further spelling mistake fixes (#10576)

* Add further spelling mistake fixes

* Fix the label for the admin TOS field

* Add missing dots at the end of the sentences

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Address crowdin issue

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Standardize the format of the words "those will" (#10619)

* Add Social Share Modal missing image to documentation (#10612)

* Fix flaky collaborative drafts specs (#10601)

* Fix flaky collaborative drafts specs

* Make sure the collaboration request was accepted before relogin

* Expect that the access request has been successfully sent

* Expect the correct page before re-visiting it

* Standardize the format of the words "I will" (#10618)

* Fix memory leak with user answers serializer (at survey export) (#10418)

* Fix memory leak with user answers serializer (at survey export)

* Simplify the answer generation

* Fix the spec after word standardization (#10624)

* Standardize the format of the words "they will" (#10617)

* Upgrade Graphql to 2.0.19 and Graphql-Api to 3.0.1 (#10606)

* Upgrade Graphql to 2.x.x and Graphql-Api to 3.0.1

* Add Release Notes information

* Revent ruby version change

* Update jest, babel and related NPM packages

* Fix the jest tests

* Fix the application helper specs

* Fix the editor asset includes with shakapacker

* Fix package-lock.json mismatch

* Fix package-lock.json mismatch

* Fix lint error

* Run prettier

* Stylelint

* Update tiptap packages to the official release version

* Disable the heading selector for the `basic` type editor

* Fix the jest tests after removing heading from the basic toolbar

And add the tests for the content toolbar.

* Adjust the system editor specs according to the heading control changes

* Update the JS config files during decidim upgrade rake task

* Move the front-end test helpers to generalized modules

To be able to utilize the front-end helpers in other tests as
well.

* Raise an error in the wysiwyg migrator if the column is not defined

* Add a comment explaining the return statement

* Correct the changed column name in the wysiwyg migration

* Change the `puts` statements to `log_info`

* Add specs for the wysiwyg migration rake tasks

---------

Co-authored-by: Sina Eftekhar <[email protected]>
Co-authored-by: Joonas <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Alexandru Emil Lupu <[email protected]>

* Improve security of social share button links

* Fix typo

* Add updateExternalDomainLinks jest test

* Refactor 'exclude ancestor classes' feature

* Ignore social share button class in external domain warning

* Add missing semicolon

* Open social share links in a new tab

* Disable external link icon for social share links

* Undo EXCLUDE_CLASSES introduction in updateExternalDomainLinks

* Introduce ExternalDomainLink class so it's consistent with ExternalLink

Convert the old updateExternalDomainLinks function to the ExternalDomainLink class.
Ditch jQuery in favor of plain JavaScript.
The main idea behind this change is to make it behave more like the ExternalLink:
* same structure
* same logic of exclusion (with the `data-xx = false` attribute)

* Document exceptions for ExternalDomainLink

* Remove leftover class from EXCLUDE_CLASSES introduction

* Fix linter offenses

* Implement external domain link exclusion for SocialShare buttons

* Update ExternalDomainLink usage in comments

* Fix trailing slash when using node.href

As the comment says, we use the href attribute (`node.getAttribute("href")`)
instead of the `node.href` property because the latter returns the URL with
a trailing slash, which is not what we want.
Before we were using jQuery for this (`$link.attr("href")`), so this
wasn't an issue, as it returned the URL withouth the trailing slash.

* input-field-generator/attribute-type-float

* type-tests

* Add Slug key for terms-of-service

* Apply review recommendations

* Fix flaky tests at proposals

* Fix the flaky proposals filtering specs

* Remove unneeded dependency @babel/plugin-proposal-private-property-in-object

* Remove unneeded dependency @babel/plugin-proposal-private-methods

* Remove unneeded dependency @babel/plugin-proposal-class-properties

…r` (#10913)

* Correct directory of TranslatablePresenceValidator

* Correct directory of UrlValidator

…0912)

* Add custom Enumerable to ActiveRecord

* Use Rails enum

* Refactor meetings enum

* trigger errors on custom modules

* More cleanup

* Refactor meetings methods

* Proposal refactor

* Refactor enum declaration

* Refactor state columns on core

* Refactor meetings

* Refactor state on proposals and collaborative drafts

* Fix seeds

* Fixing Proposal filters

* Fixing failing specs

* Rename POSIBLE_STATES to STATES

* Patch the migrations

* Apply review Recommendations

* Apply review recommendations

* Fix failing specs

* More specs fixed

* Apply suggestions from code review

Co-authored-by: Antti Hukkanen <[email protected]>

---------

Co-authored-by: Antti Hukkanen <[email protected]>

* Add seeded Trustees

* Use new ruby syntax by omitting the hash value

…10902)

* Show message on the Election form about the Organization time zone

* Add examples for showing current organization time zone

* Add "creating an election" example title description

* Fix typo

* Fix Capybara/NegationMatcher rubocop rule

* Fix Style/RedundantConstantBase rubocop rule

* Fix Style/MagicCommentFormat rubocop

* Fix Lint/DuplicateMagicComment rubocop

* Fix Lint/RedundantCopDisableDirective rubocop rule

* Apply review recommendations

* Fix Style/HashSyntax rubocop rule

* Fix RSpec/EmptyLineAfterExampleGroup rubocop rule

* Fix RSpec/ContextWording rubocop rule

* Fix RSpec/BeEmpty rubocop rule

* Fix RSpec/Rails/HaveHttpStatus rubocop rule

* Fix Rails/ActiveSupportOnLoad rubocop rule

* Fix RSpec/Rails/TravelAround rubocop rule

* Fix RSpec/ContainExactly rubocop rule

* Fix Rails/RootPathnameMethods rubocop rule

* Fix RSpec/MatchArray rubocop rule

* Refactor intiative wizard

* Fix the initiative creation

* Fixing failing specs

* Apply review recommendations

* Update decidim-initiatives/app/models/decidim/initiative.rb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Apply review recommendations

* Fix the user group creation

* Small refactor on initiatives

* Add spec for custom signature end date in update command

* Update decidim-initiatives/app/controllers/decidim/initiatives/create_initiative_controller.rb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update decidim-initiatives/lib/decidim/initiatives/engine.rb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Apply latest review recommendations

* Add area spec

* Apply suggestions from code review

Co-authored-by: Antti Hukkanen <[email protected]>

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Antti Hukkanen <[email protected]>

* Change to display initiatives after creation

* Rspec test added to viewing initiatives

* Fix do not count blocked users to stats

* Add date condition for blocked or deleted users

* fix report blogs

* lint

* lint

…our (#10900)

* Change the Elections' setup minimum hours before start setting to 1 hour

* Fix specs

* Change value on defaul initializer when secrets isn't configured

Suggested by code review

* New translations en.yml (Czech)

* New translations en.yml (German)

* New translations en.yml (Greek)

* New translations en.yml (Basque)

* New translations en.yml (Finnish)

* New translations en.yml (Irish)

* New translations en.yml (Hungarian)

* New translations en.yml (Italian)

* New translations en.yml (Japanese)

* New translations en.yml (Lithuanian)

* New translations en.yml (Dutch)

* New translations en.yml (Norwegian)

* New translations en.yml (Polish)

* New translations en.yml (Portuguese)

* New translations en.yml (Swedish)

* New translations en.yml (Turkish)

* New translations en.yml (Chinese Simplified)

* New translations en.yml (Chinese Traditional)

* New translations en.yml (Galician)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Latvian)

* New translations en.yml (French, Canada)

* New translations en.yml (Luxembourgish)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Finnish (plain))

* New translations en.yml (French)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (French, Canada)

* New translations en.yml (French, Canada)

* New translations en.yml (French, Canada)

* New translations en.yml (French, Canada)

* New translations en.yml (French, Canada)

* New translations en.yml (French, Canada)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (Czech)

* New translations en.yml (Czech)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Finnish)

* New translations en.yml (Finnish)

* New translations en.yml (Basque)

* New translations en.yml (Japanese)

* New translations en.yml (Chinese Traditional)

* New translations en.yml (Chinese Traditional)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (Hungarian)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (Czech)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Romanian)

* New translations en.yml (Romanian)

* New translations en.yml (Romanian)

* New translations en.yml (Romanian)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (Finnish (plain))

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (Czech)

* New translations en.yml (French)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (French, Canada)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (French)

* New translations en.yml (French)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (French, Canada)

* New translations en.yml (French, Canada)

* New translations en.yml (French)

* New translations en.yml (Spanish)

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (Catalan)

* New translations en.yml (Basque)

* New translations en.yml (French)

* New translations en.yml (French)

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (Finnish)

* New translations en.yml (Finnish)

* New translations en.yml (Finnish)

* New translations en.yml (Romanian)

* New translations en.yml (French)

* New translations en.yml (Czech)

* New translations en.yml (Basque)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (French, Canada)

* New translations en.yml (French, Canada)

* New translations en.yml (French, Canada)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Finnish (plain))

* New translations en.yml (Finnish (plain))

* New translations en.yml (Finnish (plain))

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (Chinese Traditional)

* New translations en.yml (Greek)

* New translations en.yml (Greek)

* New translations en.yml (Greek)

* New translations en.yml (Greek)

* New translations en.yml (Basque)

* New translations en.yml (Basque)

* New translations en.yml (Basque)

* New translations en.yml (German)

* New translations en.yml (Hungarian)

* New translations en.yml (Romanian)

* New translations en.yml (French)

* New translations en.yml (Spanish)

* New translations en.yml (Spanish)

* New translations en.yml (Spanish)

* New translations en.yml (Spanish)

* New translations en.yml (Spanish)

* New translations en.yml (Spanish)

* New translations en.yml (Spanish)

* New translations en.yml (Arabic)

* New translations en.yml (Catalan)

* New translations en.yml (Czech)

* New translations en.yml (Basque)

* New translations en.yml (Finnish)

* New translations en.yml (Irish)

* New translations en.yml (Italian)

* New translations en.yml (Japanese)

* New translations en.yml (Lithuanian)

* New translations en.yml (Norwegian)

* New translations en.yml (Polish)

* New translations en.yml (Portuguese)

* New translations en.yml (Slovenian)

* New translations en.yml (Swedish)

* New translations en.yml (Turkish)

* New translations en.yml (Chinese Simplified)

* New translations en.yml (Chinese Traditional)

* New translations en.yml (Galician)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (French, Canada)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Finnish (plain))

* New translations en.yml (Hungarian)

* New translations en.yml (Hungarian)

* New translations en.yml (Czech)

* New translations en.yml (Finnish)

* New translations en.yml (Finnish)

* New translations en.yml (Greek)

* New translations en.yml (Greek)

* New translations en.yml (French)

* New translations en.yml (French)

* New translations en.yml (Finnish)

* New translations en.yml (French, Canada)

* New translations en.yml (French, Canada)

* New translations en.yml (Finnish (plain))

* New translations en.yml (Finnish (plain))

* New translations en.yml (Finnish (plain))

* New translations en.yml (German)

* New translations en.yml (German)

* New translations en.yml (Hungarian)

* New translations en.yml (Romanian)

* New translations en.yml (French)

* New translations en.yml (Spanish)

* New translations en.yml (Arabic)

* New translations en.yml (Catalan)

* New translations en.yml (Czech)

* New translations en.yml (German)

* New translations en.yml (Greek)

* New translations en.yml (Basque)

* New translations en.yml (Finnish)

* New translations en.yml (Italian)

* New translations en.yml (Japanese)

* New translations en.yml (Lithuanian)

* New translations en.yml (Dutch)

* New translations en.yml (Norwegian)

* New translations en.yml (Polish)

* New translations en.yml (Portuguese)

* New translations en.yml (Slovak)

* New translations en.yml (Swedish)

* New translations en.yml (Turkish)

* New translations en.yml (Chinese Simplified)

* New translations en.yml (Chinese Traditional)

* New translations en.yml (Galician)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Indonesian)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Latvian)

* New translations en.yml (French, Canada)

* New translations en.yml (Luxembourgish)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Finnish (plain))

* New translations en.yml (Spanish)

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (Catalan)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Spanish, Mexico)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Spanish, Paraguay)

* New translations en.yml (Hungarian)

* New translations en.yml (Czech)

…es (#10934)

* Fix user and group related migrations calling the actual records

* Fix few more cases with possible references to the user model

* Fix the sortition authors to polymorphic spec

* Fix issues with the inheritance columns in the migration records

)

- If the environment config has already configured the session
  store, do not reconfigure it
- Remove the unnecessary same site protection config since Rails
  6.1

* Fix error message mismatch in election

* Fixing hour pluralization after #10900

* Add spec for checking that the Page inside of an Initiative works

* Fix bug during creation of Initiatives

* Fix bug on seeding Initiatives

* Add one time action on RELEASE_NOTES with the fix

* Fix rubocop offense

* Fix rubocop offense

* Fix path and filename of the rake task

* Fix typo

Suggested on code review

Co-authored-by: Alexandru Emil Lupu <[email protected]>

* Add PR id in RELEASE_NOTES

Suggested on code review

Co-authored-by: Alexandru Emil Lupu <[email protected]>

---------

Co-authored-by: Alexandru Emil Lupu <[email protected]>

* Fix Style/Semicolon rubocop rule

* Fix Style/RedundantStringEscape rubocop rule

* Fix Style/RedundantParentheses rubocop rule

* Fix Style/ClassEqualityComparison rubocop rule

* Fix RSpec/ClassCheck rubocop rule

* Fix RSpec/SortMetadata rubocop rule

* Fix RSpec/NoExpectationExample rubocop rule

* Fix RSpec/SkipBlockInsideExample rubocop rule

* Fix Style/EachForSimpleLoop rubocop rule

* Fix Rails/ActionControllerFlashBeforeRender rubocop rule

* Fix Style/ArrayIntersect rubocop rule

* Fix Style/MinMaxComparison rubocop rule

* Fix Style/RedundantRegexpEscape rubocop rule

* Fix Style/MapToSet rubocop rule

* Fix Capybara/SpecificMatcher rubocop rule

* Fix Style/ConcatArrayLiterals rubocop rule

* Fix Capybara/SpecificActions rubocop rule

* Fix failing spec

* Apply review recommendation

* Update decidim-comments/spec/cells/decidim/comments/comment_form_spec.rb

Co-authored-by: Antti Hukkanen <[email protected]>

* Fix query

---------

Co-authored-by: Antti Hukkanen <[email protected]>

* Don't allow access to admin panel without ToS acceptance

* Add redirection to previous page after accepting ToS

* Use have_content instead of have_text

* Running spellcheck linters

* Fix specs

* Fix permissions on Templates when user is not admin

* Fix specs

* Fix i18n string scope from merge

* Workaround for admin ToS acceptance in Initiatives

After #5736, the initiatives' authors and commitee members should not
have access to the admin panel.

The problem is that with the change of the Terms of Service acceptance
in the admin panel this is changing, so there's still some leftovers in
the initiatives' permissions.

As I only want to focus on ToS acceptance for now, I'll skip these specs
and fix the real problem (cleaning the leftovers from #5736) on another
PR to keep this small.

* Fix typo

* Fix for possible Cookie overflow with a long list of URL params

Detected by code review

* Remove unecessary namespaces

* Fix spec

* Bring consistency to the spec messages

* "has not accepted" sounds better than "did not accepted"
* sometimes I was using "has a message" and other times "shows a
  message"
* sometimes we were using ToS and other times TOS

* Add missing specs for Templates' specs

* Remove unecessary return

Apply suggestions from code review

Co-authored-by: Antti Hukkanen <[email protected]>

* Fix the stored request.path to not mess with the frontend's stored location

Apply suggestions from code review

Co-authored-by: Antti Hukkanen <[email protected]>

* Fetch from stored_location_for so the session value is cleaned

Apply suggestions from code review

Co-authored-by: Antti Hukkanen <[email protected]>

* Fix traits usages in factories calls

Apply suggestions from code review

Co-authored-by: Antti Hukkanen <[email protected]>

* Introduce "needs admin TOS accepted" shared example

* Fix rubocop offenses

* Fix rubocop offenses

* Make the user configurable for "needs admin TOS accepted" shared example

* Fix rubocop offense

* Refactor spec to shared examples

* Add example for roles that aren't admin

---------

Co-authored-by: Alexandru Emil Lupu <[email protected]>
Co-authored-by: Antti Hukkanen <[email protected]>

* Move "Releases" page to "maintainers/" directory

* Add "Security" procedure for Maintainers

* Fix spellchecker offense

* Be consistent with the usage of XXX as placeholder

* Ignore the codeclimate fixme rule for this file

* Make organizations' colors seeds random

* Fix rubocop offenses

* add triadic color calculator

* fix erblint

* fix i18n

* do nothing if trigger is not present

* remove todo (code review)

* Remove URL from i18n file and make the link similar to the one in the colors_warning_html key

* Move the title to the i18n file

Suggested by code review

* Extract inline CSS to its own file

* Make the translation tag consistent with the ones from _minimap.html.erb

Suggested on code review

* Make clear that primarySat means primarySaturation

* Use previous selected colors on first load

* Fix eslint offenses

* Add spec

* Fix stylelint offenses

* Use html suffix convention and embed the URL in the translation string

Co-authored-by: Alexandru Emil Lupu <[email protected]>

* Make consistent the usage of external link in the colors_warning_html key

---------

Co-authored-by: Hugoren Martinako <[email protected]>
Co-authored-by: Alexandru Emil Lupu <[email protected]>

* Load the editor assets only when there is an editor on the page

* Move the rich text display styles to the main stylesheets

In order to display the rich text generated content correctly,
we want the display styles to be part of the main stylesheet.

* Add ESLint and Stylelint to component template

* Add the private field to the package.json template

* Fix the package.json expectation

* Fix to Proposal cards CSS in Processes

* Update change to revert columns

* Revert "Fix to Proposal cards CSS in Processes"

This reverts commit ac69415.

* Update to fix highlighted proposals

* fix to condition of collapsible-list

* indentation fix

…10385)

* Partial refactor of LastActivity query

* Apply review recommendations

* Fix last_activity log

* Fix factory

* Fix factory

* add test send a test mail to the logged user

* test it will check email has been sent

* test it will check email has been sent

* test admin send emails from index

* test admin receives the test newsletter

* Update code after review suggestions

* remove restriction to send a newsletter email

* fix string error in newsletters test

* add context to test title and remove yarn.lock file

* add context to test description

* replace if ! condition by unless

---------

Co-authored-by: Ivan Vergés <[email protected]>

…disabled (#11070)

* avoid password change to be requested when user registration mode is disabled

* admin_password_expiration_days accessor set to 90 days

* rubocop lint

* Remove bootstrap-tagsinput npm package

* Add tom-select npm package

* Remove 'No results found' message

* Fix CSS margins

* Sync input-tags.scss from decidim-core with the decidim-system CSS

* Enable 'remove button' feature

* Fix eslint offenses

* Reference the same SCSS file instead of duplicating it

Suggested by code review

* Add Content Security Policy concern

* Add inclusion of Concern

* Add CSP settings

* Refactor

* Extract CSP in own class

* Running linters, add Headers module

* Add documentation, value to initializer

* Fix failing specs

* Apply review Recommendations

* Update the documentation links

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Remove jsdeliver

* Apply review recommendations

* Update the documentation readme

* Running linters

* Revert jsdeliver.net

* Fix invalid rule spec

* Fixing code review bug

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Comply with the latest changes

* Change the documentation

* Lock sass-embedded

* Add guard clause

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>