[pull] develop from decidim:develop

.codeclimate.yml

@@ -79,6 +79,7 @@ plugins:
       - decidim-core/app/assets/javascripts/decidim/core/bundle.js
       - decidim-elections/lib/decidim/elections/jwk_utils.rb
       - decidim-dev/config/rubocop/ruby.yml
+      - docs/modules/develop/pages/maintainers/security.adoc
 
   grep:
     enabled: true

.github/actions/module-rspec/action.yml

@@ -47,7 +47,7 @@ runs:
     - run: mkdir -p ./spec/decidim_dummy_app/tmp/screenshots
       name: Create the screenshots folder
       shell: "bash"
-    - uses: nanasess/setup-chromedriver@v1
+    - uses: nanasess/setup-chromedriver@v2
     - run: RAILS_ENV=test bundle exec rails assets:precompile
       name: Precompile assets
       working-directory: ./spec/decidim_dummy_app/

.github/workflows/ci_core_system.yml

@@ -68,7 +68,7 @@ jobs:
           node_version: ${{ env.NODE_VERSION }}
       - run: |
           sudo Xvfb -ac $DISPLAY -screen 0 1920x1084x24 > /dev/null 2>&1 & # optional
-          bundle exec rake parallel:spec[^spec/system]
+          bundle exec rspec spec/system
         name: RSpec
         working-directory: ${{ env.DECIDIM_MODULE }}
         env:

.github/workflows/lint_pr_format.yml

@@ -16,7 +16,7 @@ jobs:
     steps:
       - uses: deepakputhraya/action-pr-title@master
         with:
-          disallowed_prefixes: "feat/,chore/,build/,ci/,refactor/,docs/,wip/"
+          disallowed_prefixes: "feat/,feature/,fix/,chore/,build/,ci/,refactor/,docs/,wip/,fix:"
           prefix_case_sensitive: false
           min_length: 5
           max_length: 100

.gitpod.Dockerfile

@@ -3,7 +3,8 @@ USER root
 
 # Install PostgreSQL
 ENV PGVERSION=14
-RUN apt-get install -y postgresql postgresql-client postgresql-server-dev-${PGVERSION} libpq-dev
+RUN apt-get update \
+  && apt-get install -y postgresql postgresql-client postgresql-server-dev-${PGVERSION} libpq-dev
 
 # Setup the database user env vars, drop the default database cluster and change the folders to the workspace
 # This makes it possible to persist the database within the workspace

.rubocop.yml

@@ -48,3 +48,51 @@ Rails/Output:
 Rails/Exit:
   Exclude:
     - lib/decidim/git_backport_manager.rb
+
+RSpec/NoExpectationExample:
+  Exclude:
+    - decidim-admin/spec/system/participatory_space_private_user_spec.rb
+    - decidim-comments/spec/services/decidim/comments/comment_creation_spec.rb
+    - decidim-conferences/spec/cells/decidim/conferences/conference_speaker_cell_spec.rb
+    - decidim-core/spec/cells/decidim/date_range_cell_spec.rb
+    - decidim-core/spec/commands/decidim/unsubscribe_settings_spec.rb
+    - decidim-core/spec/controllers/registrations_controller_spec.rb
+    - decidim-core/spec/lib/importers/import_manifest_spec.rb
+    - decidim-core/spec/lib/map/geocoding_spec.rb
+    - decidim-core/spec/lib/participatory_space_manifest_spec.rb
+    - decidim-core/spec/services/decidim/events_manager_spec.rb
+    - decidim-core/spec/services/decidim/settings_change_spec.rb
+    - decidim-core/spec/services/decidim/zip_stream/zip_stream_writer_spec.rb
+    - decidim-core/spec/tasks/decidim_tasks_right_to_be_forgotten_spec.rb
+    - decidim-elections/spec/lib/tasks/decidim_election_generate_identification_keys_spec.rb
+    - decidim-elections/spec/lib/tasks/decidim_election_scheduled_tasks_spec.rb
+    - decidim-elections/spec/shared/vote_examples.rb
+    - decidim-elections/spec/system/key_ceremony_spec.rb
+    - decidim-elections/spec/system/vote_online_inside_a_voting_spec.rb
+    - decidim-initiatives/spec/system/admin/update_initiative_spec.rb
+    - decidim-initiatives/spec/system/initiative_signing_spec.rb
+    - decidim-meetings/spec/commands/admin/export_meeting_registrations_spec.rb
+    - decidim-proposals/spec/lib/decidim/proposals/markdown_to_proposals_spec.rb
+    - decidim-proposals/spec/shared/import_proposals_examples.rb
+    - decidim-proposals/spec/shared/proposals_wizards_examples.rb
+    - decidim-proposals/spec/system/admin/admin_manages_participatory_texts_spec.rb
+    - decidim-proposals/spec/system/participatory_texts_spec.rb
+    - decidim-participatory_processes/spec/system/participatory_processes_spec.rb
+
+# fix these rules later
+Capybara/SpecificFinders:
+  Enabled: false
+
+Capybara/CurrentPathExpectation:
+  Enabled: false
+
+RSpec/IndexedLet:
+  Enabled: false
+
+RSpec/Rails/InferredSpecType:
+  Enabled: false
+
+Rails/HelperInstanceVariable:
+  Enabled: false
+
+# EOF fix these rules later

.spelling.yml

@@ -1,4 +1,5 @@
 exclude_paths:
+  - \.(gem|jpg|jpeg|png|ico|pdf|odt|xlsx|jwk|pem)$
   - config/locales/((?!en).)*\.yml
   - decidim-dev/lib/decidim/dev/assets/participatory_text.md
   - decidim-core/lib/decidim/db/common-passwords.txt
@@ -60,6 +61,8 @@ forbidden:
   "you’ve": you have
   "I've": I have
   "I’ve": I have
+  "I'm": I am
+  "I’m": I am
   "they've": they have
   "they’ve": they have
   "would've": would have

CONTRIBUTING.adoc

@@ -11,7 +11,7 @@ Come find us at https://matrix.to/#/#decidim:matrix.org[our Matrix.org space]. W
 == Did you find a bug?
 
 * *Do not open up a GitHub issue if the bug is a security vulnerability in Decidim*, and instead send us an email to security [at] decidim.org.
-See https://github.com/decidim/decidim/blob/develop/SECURITY.adoc[full security policy].
+See https://github.com/decidim/decidim/blob/develop/SECURITY.md[full security policy].
 * *Ensure the bug was not already reported* by searching on GitHub under https://github.com/decidim/decidim/issues[Issues] and on https://meta.decidim.org/processes/bug-report/f/210/proposals[Metadecidim].
 * If you are unable to find an open issue addressing the problem, https://github.com/decidim/decidim/issues/new?template=Bug_report.md[open a new one on GitHub].
 Be sure to include a *title and clear description*, as much relevant information as possible, and a *code sample* or an *executable test case* demonstrating the expected behavior that is not occurring.

Gemfile

@@ -15,18 +15,16 @@ gem "bootsnap", "~> 1.4"
 
 gem "puma", ">= 5.6.2"
 
-gem "faker", "~> 2.14"
-
 group :development, :test do
   gem "byebug", "~> 11.0", platform: :mri
 
   gem "decidim-dev", path: "."
 
-  gem "brakeman", "~> 5.2"
+  gem "brakeman", "~> 5.4"
   gem "net-imap", "~> 0.2.3"
   gem "net-pop", "~> 0.1.1"
   gem "net-smtp", "~> 0.3.1"
-  gem "parallel_tests", "~> 3.7"
+  gem "parallel_tests", "~> 4.2"
 end
 
 group :development do