Patch for build libs warning (with PostCSS/autoprefixer) for line-highlight plugin's CSS color-adjust prop #3672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For quite a while now, I've gotten vite/tailwind warnings during builds when using the ever awesome prism(js) as a dep.
Today though, I found a random spare half hour to dig a bit on it...
Ok so it turns out that it's possible to get rid of the warning and I found at least one other awesome dev that did a super similar fix (3617).
I totally understand the hold for v2, and this isn't "security" per say... but then again I figured maybe this pull release (3617) wasn't merged because the suggested change dropped the old
color-adjust: exact;
line. That might trigger a need to re-test/recompile/etc.Now don't get me wrong, I totally did NOT check if a lack of
color-adjust: exact;
breaks old IE consumption of prismjs' line-highlight plugin's awesomeness. That's way over my budget for today's time investment.But I DO know that adding the newer
print-color-adjust: exact;
prop/value prior to the old line, does in fact fix the warning that vite/tailwind (and likely a few other build libs using autoprefixer and postcss) are throwing over the now depreciatedcolor-adjust
prop.So hopefully this is an easy merge, even though it's not security related.
(unless we consider "security" as a dev's sanity when non-coders can access our build logs and get panic attacks from thinking this warning will melt down reality... but I digress.)
Please let me know if there's anything I can or need to do, as I understand how much work it is to make a major version update, albeit not for code as useful and awesome as this code is!
Cheers and thank you either way! 😄