Skip to content

enhance download_and_extract #8214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jerome-Hsieh wants to merge 2 commits into from
Closed

enhance download_and_extract #8214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e1e13
enhance download_and_extract
Jerome-Hsieh Nov 16, 2024
06d2ff5
enhance download_and_extract
Jerome-Hsieh Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions monai/apps/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,18 @@ def download_and_extract(
be False.
progress: whether to display progress bar.
"""
with tempfile.TemporaryDirectory() as tmp_dir:
filename = filepath or Path(tmp_dir, _basename(url)).resolve()
download_url(url=url, filepath=filename, hash_val=hash_val, hash_type=hash_type, progress=progress)
extractall(filepath=filename, output_dir=output_dir, file_type=file_type, has_base=has_base)
urlFilenameExtension = ''.join(Path(".", _basename(url)).resolve().suffixes)
if filepath:
FilepathExtenstion = ''.join(Path(".", _basename(filepath)).resolve().suffixes)
if urlFilenameExtension != FilepathExtenstion:
raise NotImplementedError(
f'The file types do not match: url={urlFilenameExtension}, but filepath={FilepathExtenstion}'
)
else:
with tempfile.TemporaryDirectory() as tmp_dir:
if filepath:
filename = filepath
else:
filename = Path(tmp_dir, _basename(url)).resolve()
download_url(url=url, filepath=filename, hash_val=hash_val, hash_type=hash_type, progress=progress)
extractall(filepath=filename, output_dir=output_dir, file_type=file_type, has_base=has_base)
Loading