Skip to content

fix: handle metadata loading and shape calculation in transforms #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericspod merged 3 commits into from
May 16, 2025
Merged

fix: handle metadata loading and shape calculation in transforms #1990

ericspod merged 3 commits into from
May 16, 2025

Conversation

@Kirscher
Copy link
Contributor

@Kirscher Kirscher commented May 15, 2025

Fixes # .
handle metadata loading and shape calculation in transforms

Description

  • Add image_only=False and ensure_channel_first=True to LoadImaged transform to properly load metadata
  • Fix shape mismatch in PreprocessAnisotropic.calculate_new_shape by handling 4D input shapes
  • Addresses KeyError: 'image_meta_dict' and ValueError: operands could not be broadcast together

Note: The metadata loading issue might be related to MONAI version differences.
Current version: 1.4.0

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.

ericspod
ericspod reviewed May 15, 2025
View reviewed changes
@ericspod ericspod requested a review from KumoLiu May 15, 2025 21:57
ericspod
ericspod approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm good with this now. Please address the DCO issue and we can merge.

@ericspod ericspod enabled auto-merge (squash) May 16, 2025 13:14
@Kirscher
fix: DCO issue
1a67cab 
DCO Remediation Commit for Tristan Kirscher <[email protected]>

I, Tristan Kirscher <[email protected]>, hereby add my Signed-off-by to this commit: f8810ad

Signed-off-by: Tristan Kirscher <[email protected]>


Signed-off-by: Tristan Kirscher <[email protected]>
auto-merge was automatically disabled May 16, 2025 13:30

Head branch was pushed to by a user without write access

@Kirscher
Copy link
Contributor Author

Kirscher commented May 16, 2025

DCO addressed, thanks

@ericspod ericspod merged commit 75c44e0 into Project-MONAI:main May 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericspod ericspod ericspod approved these changes

@KumoLiu KumoLiu Awaiting requested review from KumoLiu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kirscher @ericspod