Skip to content

bug/issue 1475 reconcile page level custom title and layout <title> merging when using active content #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

bug/issue 1475 reconcile page level custom title and layout <title> merging when using active content #1526

merged 2 commits into from
Jul 4, 2025

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 29, 2025 •
edited
Loading

Related Issue

regression related to #1475

reproduction - ProjectEvergreen/www.greenwoodjs.dev#211 (comment)

Documentation

  1. called out precedence of frontmatter title - document latest default layouts and pages content and merging behavior www.greenwoodjs.dev#217

Summary of Changes

  1. address reconciliation of title between parent and child layouts
  2. add test cases to cover additional use cases

TODO

  1. need to better handle local page titles and cover with test cases

@thescientist13 thescientist13 added this to the 1.0 milestone Jun 29, 2025
@thescientist13 thescientist13 self-assigned this Jun 29, 2025
@thescientist13 thescientist13 added the bug Something isn't working label Jun 29, 2025
@thescientist13 thescientist13 added invalid This doesn't seem right website Tasks related to the projects website / documentation CLI alpha.3 v0.33.0 labels Jun 29, 2025
@thescientist13 thescientist13 mentioned this pull request Jun 29, 2025
Open
4 tasks
@thescientist13 thescientist13 linked an issue Jun 29, 2025 that may be closed by this pull request
inconsistent HTML output merging hierarchy for top level pages and layouts #1475
Closed
@thescientist13 thescientist13 added the question Further information is requested label Jul 1, 2025
@thescientist13 thescientist13 mentioned this pull request Jun 29, 2025
Closed
@thescientist13 thescientist13 removed the question Further information is requested label Jul 4, 2025
@thescientist13 thescientist13 mentioned this pull request Jul 1, 2025
Open
@thescientist13 thescientist13 force-pushed the bug/issue-1475-regression-with-title-merging branch from c569c59 to 1d654ad Compare July 4, 2025 15:12
@thescientist13 thescientist13 changed the title bug/issue 1475 reconcile parent and child layout active content title merging bug/issue 1475 reconcile page level custom title and layout title merging when using active content Jul 4, 2025
@thescientist13 thescientist13 changed the title bug/issue 1475 reconcile page level custom title and layout title merging when using active content bug/issue 1475 reconcile page level custom title and layout <title> merging when using active content Jul 4, 2025
@thescientist13 thescientist13 merged commit f992744 into master Jul 4, 2025
12 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1475-regression-with-title-merging branch July 4, 2025 15:30
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in [Greenwood] Phase 10 - Ecosystem Compat Jul 4, 2025
@thescientist13 thescientist13 mentioned this pull request Aug 3, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
alpha.3 bug Something isn't working CLI invalid This doesn't seem right v0.33.0 website Tasks related to the projects website / documentation
Projects
[Greenwood] Phase 10 - Ecosystem Compat
Status: ✅ Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

inconsistent HTML output merging hierarchy for top level pages and layouts
1 participant
@thescientist13