chore: upgrade Greenwood v0.33.0 #211
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for super-tapioca-5987ce ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
56 tasks
This comment was marked as resolved.
This comment was marked as resolved.
thescientist13
added
the
needs upstream
2 tasks
thescientist13
removed
the
needs upstream
thescientist13
force-pushed
the
chore/upgrade-greenwood-v0.33.0
branch
from
d1f6010 to
9d508a7
Compare
1 task
thescientist13
added
the
needs upstream
|
getting a build error in the CSS Modules plugin (again...) SyntaxError [Error]: Unterminated string in JSON at position 8192 (line 1 column 8193)
at JSON.parse (<anonymous>)
at getCssModulesMap (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/@greenwood/plugin-css-modules/src/index.js:29:26)
at ScanForCssModulesResource.shouldIntercept (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/@greenwood/plugin-css-modules/src/index.js:194:27)
at getCustomLoaderResponse (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/@greenwood/cli/src/loader.js:71:49)
at async load (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/@greenwood/cli/src/loader.js:113:28)
at async nextLoad (node:internal/modules/esm/hooks:748:22)
at async Hooks.load (node:internal/modules/esm/hooks:385:20)
at async handleMessage (node:internal/modules/esm/worker:199:18) |
thescientist13
added
enhancement
|
On top of the CSS Modules issue, this project will also suffer from ProjectEvergreen/greenwood#1558 |
2 tasks
thescientist13
changed the title
thescientist13
removed
the
needs upstream
thescientist13
force-pushed
the
chore/upgrade-greenwood-v0.33.0
branch
from
2865b0b to
a6f9312
Compare
thescientist13
moved this from 🏗 In progress
to 👀 In review
in [Greenwood] Phase 10 - Ecosystem Compat
|
Not sure if this is also related to the concurrency refactor, but I think we need more ThreadPools or something? (node:85019) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 Symbol(kWorkerFreedEvent) listeners added to [WorkerPool]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
(Use `node --trace-warnings ...` to show where the warning was created) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
ProjectEvergreen/greenwood#1499
Summary of Changes
TODO
@imports #214<title>merging when using active content greenwood#1526Not sure if this is also related to the concurrency refactor, but I think we need more ThreadPools or something?