Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address various comments from Spearbit review #32

Merged
merged 19 commits into from
Feb 28, 2024
Merged

address various comments from Spearbit review #32

merged 19 commits into from
Feb 28, 2024

Commits on Feb 27, 2024

  1. fix comment in AmountDeriver

    @0age
    0age committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    d17e576 View commit details
    Browse the repository at this point in the history

  2. fix comment in ConsiderationDecoder

    @0age
    0age committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c1dc0c9 View commit details
    Browse the repository at this point in the history

  3. improve comments around modified params

    @0age
    0age committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ea11a5d View commit details
    Browse the repository at this point in the history

  4. fix a comment

    @0age
    0age committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    17720b1 View commit details
    Browse the repository at this point in the history

  5. fix comment in ConsiderationEncoder

    @0age
    0age committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f217574 View commit details
    Browse the repository at this point in the history

  6. add a clarification about event data copying

    @0age
    0age committed Feb 27, 2024
    2 Configuration menu
    Copy the full SHA
    72e8e96 View commit details
    Browse the repository at this point in the history

  7. clarify constant name

    @0age
    0age committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2f4598f View commit details
    Browse the repository at this point in the history

  8. clarify another constant name

    @0age
    0age committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    55d72de View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. add natspec and a small optimization to basic order status updates

    @0age
    0age committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e3ee057 View commit details
    Browse the repository at this point in the history

  2. add natspec for CriteriaResolution

    @0age
    0age committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bb44017 View commit details
    Browse the repository at this point in the history

  3. natspec and general cleanup in ZoneInteraction

    @0age
    0age committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e736d1d View commit details
    Browse the repository at this point in the history

  4. clean up OrderFulfiller and add missing natspec

    @0age
    0age committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    da0684c View commit details
    Browse the repository at this point in the history

  5. progress on max line length 80

    @0age
    0age committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5a4f4cb View commit details
    Browse the repository at this point in the history

  6. heh actually sstore it

    @0age
    0age committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    27671cd View commit details
    Browse the repository at this point in the history

  7. small cleanup of OrderValidator

    @0age
    0age committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3cfda8d View commit details
    Browse the repository at this point in the history

  8. tiny optimization and lots of formatting tweaks to decoder

    @0age
    0age committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bc82f4a View commit details
    Browse the repository at this point in the history

  9. more 80-line-limit stuff

    @0age
    0age committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d215c4c View commit details
    Browse the repository at this point in the history

  10. 80 character line limit was maybe a mistake

    @0age
    0age committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0ea718f View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into spearbit-tweaks

    @0age
    0age authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    831a1a0 View commit details
    Browse the repository at this point in the history