Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in mobile view, reduce toolbar white space #245

Open
emillipede opened this issue Nov 7, 2019 · 3 comments · Fixed by #300 or #304
Open

in mobile view, reduce toolbar white space #245

emillipede opened this issue Nov 7, 2019 · 3 comments · Fixed by #300 or #304
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed mobile work in progress

Comments

@emillipede
Copy link
Collaborator

emillipede commented Nov 7, 2019

as a:
mobile user

when I:
view the map

I want to:
see the map and not have the top toolbar overlap with the map.

on some displays, the buttons and address bar stick out below the toolbar.

on some displays, when the mini/preview window is closed, the toolbar becomes unnecessarily tall and occupies a lot of vertical space. it seems like the newer the device, the worse the problem.

might be addressed by defining the map size (to fix/define the toolbar height)?

zeplin:

Screen Shot 2019-09-23 at 11 31 05 PM

current website (on small iphone SE):

  • buttons bleed a little onto the map:
    Image from iOS (2)
  • toolbar becomes taller than necessary:
    Screen Shot 2019-11-07 at 1 57 51 PM
@emillipede emillipede added help wanted Extra attention is needed improvement mobile labels Nov 7, 2019
@emillipede emillipede added enhancement New feature or request bug Something isn't working and removed improvement enhancement New feature or request labels Apr 26, 2020
@emillipede emillipede changed the title in mobile view, define the map (to fix/define the toolbar height) in mobile view, reduce toolbar white space May 24, 2020
@emillipede emillipede reopened this Jun 14, 2020
@emillipede
Copy link
Collaborator Author

emillipede commented Jun 14, 2020

hey @mrtmrt233 I took another look, and the white space issues on mobile continue (but have changed a little bit). now a white panel appears at the bottom of the window, and it seems like it can force the top of the page off of the screen.

from iphone se:
image

testing as iphone X:
Screen Shot 2020-06-14 at 9 39 43 AM

@emillipede
Copy link
Collaborator Author

emillipede commented Jun 15, 2020

When I tested last night, it looked ok. The white space issue’s still not quite resolved (seems to inconsistently show up - not all of the time) . The saga continues @mrtmrt233 but maybe it’s OK to leave as is for now

Thank you for spending so much time on CSS, I know it’s not your favorite

imageimage

@mrtmrt233
Copy link
Contributor

Not sure what's happening, and I don't have a small device to test on...

@mrtmrt233 mrtmrt233 reopened this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed mobile work in progress
Projects
None yet
2 participants