Skip to content

notebooks updated for compatability with new ConfigManager class#12

Merged
btobers merged 2 commits intodevfrom
11_config_update
Mar 3, 2025
Merged

notebooks updated for compatability with new ConfigManager class#12
btobers merged 2 commits intodevfrom
11_config_update

Conversation

@btobers
Copy link
Collaborator

@btobers btobers commented Feb 27, 2025

Closes #11

@btobers
Copy link
Collaborator Author

btobers commented Mar 2, 2025

Updates passed in tests in PyGEM PR #79

@ddundo
Copy link

ddundo commented Mar 2, 2025

Updates passed in tests in PyGEM PR #79

That PR actually only tested simple_test and advanced_test notebooks. Could you add any other that are ready to be tested to test_notebooks.py in PyGEM-Community/PyGEM#78?

@btobers
Copy link
Collaborator Author

btobers commented Mar 2, 2025

That PR actually only tested simple_test and advanced_test notebooks. Could you add any other that are ready to be tested to test_notebooks.py in PyGEM-Community/PyGEM#78?

Yes, done. Thanks for pointing that out.

@btobers
Copy link
Collaborator Author

btobers commented Mar 2, 2025

@ddundo if you want to review this - the three main test notebooks we currently have setup simple_test, advanced_test, and advanced_test_tw all now run with the updated configuration management setup. This is good to pull to dev for now. We can add more notebooks down the road.

@btobers btobers requested review from a team and removed request for a team and ddundo March 3, 2025 03:10
@btobers btobers merged commit a40ec8d into dev Mar 3, 2025
@btobers btobers deleted the 11_config_update branch March 3, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants