Update glacierdynamics.MassRedistributionCurveModel to work with any timestep#147
Merged
btobers merged 10 commits into133-mb_dailyfrom Oct 22, 2025
Merged
Update glacierdynamics.MassRedistributionCurveModel to work with any timestep#147btobers merged 10 commits into133-mb_dailyfrom
btobers merged 10 commits into133-mb_dailyfrom
Conversation
Collaborator
Author
|
Some other updates that are included in this PR:
|
dd4824c to
9c422ca
Compare
Closed
Closed
btobers
added a commit
that referenced
this pull request
Nov 4, 2025
Closes #133. Closes #141. Closes #142. The man updates from this PR include: * Enabling the mass balance model to run on a daily timestep * Removal of nested try/except blocks in run_simulation.py so that if the specified dynamical option fails the model does not default to a fallback option * Storage of the dynamical option within the output netcdf file * Add test_postproc_binned_subannual_thick() to test04 * Update glacierdynamics.MassRedistributionCurveModel to work with any timestep (#147) --------- Co-authored-by: brandon s. tober <tobers.brandon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@drounce This PR is branched from your
133-mb_dailybranch. I went through the MassRedistributionCurveModel code and implemented some changes to properly index into the model indices following the changes to the mass balance model. I'll leave this for you to review and then we can pull it into branch133-mb_dailyto finalize the work of running daily simulations. I also created two simple tests in this PR which run the simulation script using the mass redistribution curve model or no dynamics - previously our tests were only running OGGM dynamics.