Skip to content

Use Ruff linter and formatter#57

Closed
ddundo wants to merge 6 commits intoPyGEM-Community:devfrom
ddundo:54_linting_formatting
Closed

Use Ruff linter and formatter#57
ddundo wants to merge 6 commits intoPyGEM-Community:devfrom
ddundo:54_linting_formatting

Conversation

@ddundo
Copy link
Contributor

@ddundo ddundo commented Feb 14, 2025

Closes #54.

This PR introduces the Ruff linter and formatter to check for errors and stylistic issues, including the pre-commit hook. Relevant changes are done in pyproject.toml and .pre-commit-config.yaml. The rest of changes are due to applying the pre-commit.

A few things to note:

  • I set the maximum line length to 79 as per PEP 8, but we can increase this if you prefer (personally I'm used to 88 and I find it to work well)
  • At the moment I ignored quite a few errors that couldn't be fixed automatically (see the ignore list in pyproject.toml) - I'll open a separate issue to address these
  • I added sample_data/ to .gitignore

I will change the target branch to develop if you create one (see #55).

@ddundo ddundo changed the base branch from master to dev February 14, 2025 18:36
@ddundo ddundo self-assigned this Feb 14, 2025
@ddundo ddundo mentioned this pull request Feb 14, 2025
@ddundo
Copy link
Contributor Author

ddundo commented Feb 15, 2025

Copied this branch from my fork and opened a new PR #62.

@ddundo ddundo closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up linting and formatting

1 participant