Add understand chapter for HIP Graphs #3571
Conversation
MKKnorr
force-pushed
the
understand-hip-graphs
branch
8 times, most recently
from
8808c52
to
96b0172
Compare
|
@MKKnorr CI fails, please fix it. |
MKKnorr
force-pushed
the
understand-hip-graphs
branch
from
96b0172
to
76f6524
Compare
That was just a timeout due to some downloads in the linting failing. The checks passed before. Triggering the pipeline again fixed it |
MKKnorr
force-pushed
the
understand-hip-graphs
branch
from
ab884ed
to
9c57093
Compare
I agree, but that's a better fit for a how-to page. As stated in another comment, that section will most likely not be ready soon. A tutorial is also planned, on top of this documentation |
MKKnorr
force-pushed
the
understand-hip-graphs
branch
from
9c57093
to
0ebb262
Compare
MKKnorr
force-pushed
the
understand-hip-graphs
branch
2 times, most recently
from
90728f6
to
07dce2f
Compare
MKKnorr
force-pushed
the
understand-hip-graphs
branch
from
07dce2f
to
0f98744
Compare
There was a problem hiding this comment.
This image could use a little green, or blue, or yellow.
There was a problem hiding this comment.
I agree, that the colour choice was not the best, but I tried to keep it close to the existing colour schemes. I replaced it with a (hopefully) nicer colour set
| @@ -146,7 +146,7 @@ For Linux developers, the link [here](https://github.com/ROCm/hip-tests/blob/dev | |||
|
|
|||
| ## HIP Graph | |||
There was a problem hiding this comment.
Is it necessary to have this here? it is not much more than a reference, which shows up two or three times in the index or TOC.
There was a problem hiding this comment.
I agree, that it's not really needed here, but the programming manual is going to be overhauled and probably incorporated into the runtime api how-to soon, as it is just an amalgamation of snippets on different HIP-topics.
docs/understand/hipgraph.rst
Outdated
| HIP graph | ||
| ******************************************************************************** | ||
|
|
||
| HIP graphs are an alternative way of executing work on a GPU. It can provide |
There was a problem hiding this comment.
I would eliminate this first paragraph, leave the following Beta note in place, and start this Understanding HIP Graphs topic with the Graph format text (but without the header).
docs/understand/hipgraph.rst
Outdated
|
|
||
| The standard way of launching work on GPUs via streams incurs a small overhead | ||
| for each iteration of the operation involved. For kernels that perform large | ||
| operations during an iteration this overhead usually is negligible. However |
There was a problem hiding this comment.
operations during an iteration this overhead is usually negligible. However
docs/understand/hipgraph.rst
Outdated
| The standard way of launching work on GPUs via streams incurs a small overhead | ||
| for each iteration of the operation involved. For kernels that perform large | ||
| operations during an iteration this overhead usually is negligible. However | ||
| many workloads, including scientific simulations and AI, a kernel performs a |
There was a problem hiding this comment.
in many workloads, such as scientific simulations and AI, a kernel performs a
MKKnorr
force-pushed
the
understand-hip-graphs
branch
from
0f98744
to
5f27a8a
Compare
|
Superseded by #3585 |
No description provided.