Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for HIP graphs #3585

Open
wants to merge 1 commit into
base: docs/develop
Choose a base branch
from
Open

Conversation

MKKnorr
Copy link

@MKKnorr MKKnorr commented Aug 28, 2024

This PR adds the "how-to" chapter for HIP graphs.

Note, that it currently is set to be merged with understand-hip-graphs, as it depends on its content, and it already has a PR #3571

@randyh62
Copy link

I sent comments through Teams.

docs/sphinx/_toc.yml.in Outdated Show resolved Hide resolved
@MKKnorr MKKnorr changed the base branch from understand-hip-graphs to docs/develop September 23, 2024 08:52
@MKKnorr MKKnorr changed the title Add how-to chapter for HIP graphs Add documentation for HIP graphs Sep 23, 2024
@MKKnorr MKKnorr force-pushed the how-to-hip-graphs branch 2 times, most recently from 4318aea to 60f8a71 Compare September 23, 2024 09:15
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Show resolved Hide resolved
@MKKnorr MKKnorr force-pushed the how-to-hip-graphs branch 8 times, most recently from 9a88896 to 952d47d Compare September 25, 2024 10:23
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a few minor comments.

docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
docs/how-to/hipgraph.rst Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants