Skip to content

[torch] Enable torchvision in Windows releases. #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025
Merged

[torch] Enable torchvision in Windows releases. #1190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdc5307
Set DISTUTILS_USE_SDK for torchvision build on Windows.
ScottTodd Aug 4, 2025
8e4cde1
Enable torchvision in Windows releases.
ScottTodd Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/build_windows_pytorch_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,9 @@ jobs:
python ./external-builds/pytorch/pytorch_audio_repo.py checkout \
--repo ${{ env.CHECKOUT_ROOT }}/audio \
--repo-hashtag main
# TODO(#910): Support torchvision on Windows
# python ./external-builds/pytorch/pytorch_vision_repo.py checkout
python ./external-builds/pytorch/pytorch_vision_repo.py checkout \
--repo ${{ env.CHECKOUT_ROOT }}/vision \
--repo-hashtag main

- name: Determine optional arguments passed to `build_prod_wheels.py`
if: ${{ inputs.rocm_version }}
Expand All @@ -128,6 +129,7 @@ jobs:
--index-url "${{ inputs.cloudfront_url }}/${{ inputs.amdgpu_family }}/" ^
--pytorch-dir ${{ env.CHECKOUT_ROOT }}/torch ^
--pytorch-audio-dir ${{ env.CHECKOUT_ROOT }}/audio ^
--pytorch-vision-dir ${{ env.CHECKOUT_ROOT }}/vision ^
--clean ^
--output-dir ${{ env.PACKAGE_DIST_DIR }} ^
${{ env.optional_build_prod_arguments }}
Expand Down
5 changes: 3 additions & 2 deletions external-builds/pytorch/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ patches locally until they can be upstreamed. See the
| ------------------------ | ------------- | --------------------------------------------------------------------- |
| PyTorch | ✅ Supported | ✅ Supported |
| torchaudio | ✅ Supported | ✅ Supported |
| torchvision | ✅ Supported | 🟡 In progress ([#910](https://github.com/ROCm/TheRock/issues/910)) |
| torchvision | ✅ Supported | ✅ Supported |
| Flash attention (Triton) | ✅ Supported | 🟡 In progress ([#1040](https://github.com/ROCm/TheRock/issues/1040)) |

## Build instructions
Expand Down Expand Up @@ -79,7 +79,7 @@ Now checkout repositories:
```bash
python pytorch_torch_repo.py checkout --repo C:/b/pytorch --repo-hashtag main
python pytorch_audio_repo.py checkout --repo C:/b/audio --repo-hashtag main
# TODO(#910): Support torchvision on Windows
python pytorch_vision_repo.py checkout --repo C:/b/vision --repo-hashtag main
```

Now note the gfx target you want to build for and then...
Expand Down Expand Up @@ -107,6 +107,7 @@ mix/match build steps.
--install-rocm --index-url https://d2awnip2yjpvqn.cloudfront.net/v2/gfx110X-dgpu/ \
--pytorch-dir C:/b/pytorch \
--pytorch-audio-dir C:/b/audio \
--pytorch-vision-dir C:/b/vision \
--output-dir %HOME%/tmp/pyout
```

Expand Down
7 changes: 7 additions & 0 deletions external-builds/pytorch/build_prod_wheels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,13 @@ def do_build_pytorch_vision(
}
)

if is_windows:
env.update(
{
"DISTUTILS_USE_SDK": "1",
}
)

remove_dir_if_exists(pytorch_vision_dir / "dist")
if args.clean:
remove_dir_if_exists(pytorch_vision_dir / "build")
Expand Down
Loading