-
Notifications
You must be signed in to change notification settings - Fork 84
[torch] Enable torchvision in Windows releases. #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FWIW, I use a venv on Windows alongside a python 3.12 install (same setup you screenshotted earlier). torchvision seemed to build fine for me |
Me too |
I'm suspecting the spaces in my path are causing issues (though this is the default system-wide install location) python -c "import sysconfig; print(sysconfig.get_path('include'))"
# C:\Program Files\Python312\Include Trying with an install path closer to your py -V:3.13 -c "import sysconfig; print(sysconfig.get_path('include'))"
C:\Users\Nod-Shark16\AppData\Local\Programs\Python\Python313\Include |
If that's the case, I'll add a warning to our setup instructions. I tried a few ways to escape the paths but I'll be satisfied with a build environment workaround for now. |
Man. Python has been around on Windows since forever. How is the spaces thing still an issue? XD |
Success building locally with Python 3.13 installed to
|
…1192) Follow-up to #1190. Related to #910. I'm also considering adding a check to https://github.com/ROCm/TheRock/blob/main/build_tools/hack/build_env_diag.py.
Progress on #910.
Tested at https://github.com/ROCm/TheRock/actions/runs/16728414496/job/47354811134. I'm still having trouble building locally though.