Skip to content

Conversation

ScottTodd
Copy link
Member

Progress on #910.

Tested at https://github.com/ROCm/TheRock/actions/runs/16728414496/job/47354811134. I'm still having trouble building locally though.

@jammm
Copy link
Contributor

jammm commented Aug 4, 2025

Progress on #910.

Tested at https://github.com/ROCm/TheRock/actions/runs/16728414496/job/47354811134. I'm still having trouble building locally though.

FWIW, I use a venv on Windows alongside a python 3.12 install (same setup you screenshotted earlier). torchvision seemed to build fine for me

@0xDELUXA
Copy link

0xDELUXA commented Aug 4, 2025

FWIW, I use a venv on Windows alongside a python 3.12 install (same setup you screenshotted earlier). torchvision seemed to build fine for me

Me too

@ScottTodd
Copy link
Member Author

I'm suspecting the spaces in my path are causing issues (though this is the default system-wide install location)

python -c "import sysconfig; print(sysconfig.get_path('include'))"
# C:\Program Files\Python312\Include

Trying with an install path closer to your C:\Users\jam\AppData\Local\Programs\Python\Python312\include

py -V:3.13 -c "import sysconfig; print(sysconfig.get_path('include'))"
C:\Users\Nod-Shark16\AppData\Local\Programs\Python\Python313\Include

@ScottTodd
Copy link
Member Author

If that's the case, I'll add a warning to our setup instructions. I tried a few ways to escape the paths but I'll be satisfied with a build environment workaround for now.

@jammm
Copy link
Contributor

jammm commented Aug 4, 2025

I'm suspecting the spaces in my path are causing issues (though this is the default system-wide install location)

python -c "import sysconfig; print(sysconfig.get_path('include'))"
# C:\Program Files\Python312\Include

Trying with an install path closer to your C:\Users\jam\AppData\Local\Programs\Python\Python312\include

py -V:3.13 -c "import sysconfig; print(sysconfig.get_path('include'))"
C:\Users\Nod-Shark16\AppData\Local\Programs\Python\Python313\Include

Man. Python has been around on Windows since forever. How is the spaces thing still an issue? XD

@ScottTodd
Copy link
Member Author

Success building locally with Python 3.13 installed to C:\Users\Nod-Shark16\AppData\Local\Programs\Python\Python313:

adding 'torchvision-0.24.0a0+rocmsdk20250804.dist-info/RECORD'
removing build\bdist.win-amd64\wheel

  VERSION_NAME=0.24.0a0+rocmsdk20250804
  BUILD_NUMBER=1
  FORCE_CUDA=1
  TORCHVISION_USE_NVJPEG=0
  TORCHVISION_USE_VIDEO_CODEC=0
  DISTUTILS_USE_SDK=1
Found built wheel: D:\b\vision_main\dist\torchvision-0.24.0a0+rocmsdk20250804-cp313-cp313-win_amd64.whl
++ Copy D:\b\vision_main\dist\torchvision-0.24.0a0+rocmsdk20250804-cp313-cp313-win_amd64.whl -> C:\Users\Nod-Shark16\.therock\pytorch

@ScottTodd ScottTodd merged commit 312c3b2 into main Aug 4, 2025
10 of 11 checks passed
@ScottTodd ScottTodd deleted the users/scotttodd/pytorch-vision-enable branch August 4, 2025 19:12
@github-project-automation github-project-automation bot moved this from TODO to Done in TheRock Triage Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants