Feature: Updated DTD to support annotations#236
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 87.60% 87.21% -0.40%
==========================================
Files 21 21
Lines 1783 1783
Branches 323 323
==========================================
- Hits 1562 1555 -7
- Misses 183 189 +6
- Partials 38 39 +1 ☔ View full report in Codecov by Sentry. |
904dead to
998b4c4
Compare
998b4c4 to
2e60bf0
Compare
dhdaines
requested changes
Aug 6, 2024
Collaborator
dhdaines
left a comment
There was a problem hiding this comment.
This seems good! Except, should we increment the version number on the DTD?
Collaborator
Author
I will bump up the format version to 1.2 |
Member
|
I'm guessing CI fails here due (at least in part) to the panphon issue. Releasing g2p 2.1.0 or restricting |
b11b79f to
3df7249
Compare
3df7249 to
7b9069a
Compare
Member
|
I fixed CI now. There were two problems, in the end:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
The goal of the PR is to provide support for annotation layers in the read along. If a .readalong has annotation layers, it should be acceptable to the CLI
Fixes?
n/a
Feedback sought?
sanity check
Priority?
high
Tests added?
yes
How to test?
cd test/data; readalongs align -o html -f -l fra ej-fra-annotated.readalong ej-fra.m4a ej-fra-annotatedConfidence?
High
Version change?
n/a
required for ReadAlongs/Studio-Web#330