Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure analytics observer instance is not lost. #2550

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Ensure analytics observer instance is not lost. #2550

merged 4 commits into from
Jul 11, 2023

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 requested a review from a team June 13, 2023 11:00
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023 •
edited
Loading

Codecov Report

Merging #2550 (20139a5) into master (681ed1a) will not change coverage.
The diff coverage is n/a.

❗ Current head 20139a5 differs from pull request most recent head 6a68703. Consider uploading reports for the commit 6a68703 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2550    +/-   ##
========================================
  Coverage   57.91%   57.91%            
========================================
  Files          92       92            
  Lines        2756     2756            
  Branches      702      648    -54     
========================================
  Hits         1596     1596            
- Misses       1048     1159   +111     
+ Partials      112        1   -111

see 31 files with indirect coverage changes

@Hyperkid123
Copy link
Contributor Author

/retest

@Hyperkid123 Hyperkid123 merged commit 0812a14 into RedHatInsights:master Jul 11, 2023
6 checks passed
@Hyperkid123 Hyperkid123 deleted the oserver-instance branch July 11, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelhala karelhala karelhala approved these changes

@fhlavac fhlavac fhlavac approved these changes

@ryelo ryelo Awaiting requested review from ryelo ryelo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hyperkid123 @codecov-commenter @karelhala @fhlavac