feat(RHINENG-7074): Update inventory fec config #2194

adonispuente · 2024-05-09T19:57:55Z

No description provided.

fec.config.js

bastilian · 2024-05-13T21:35:03Z

@adonispuente We should add .cache to the .gitignore and not commit the contents of this directory.

package.json

pr_check.sh

src/components/InventoryGroups/Modals/ConfirmSystemsAddModal.js

.travis.yml

fec.config.js

src/components/InventoryHostStaleness/BaseDropDown.js

src/components/ImmutableDevices/helpers.js

package.json

codecov-commenter · 2024-06-07T11:15:13Z

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.69%. Comparing base (894b14d) to head (3f996b9).
Report is 2 commits behind head on master.

Files	Patch %	Lines
.../components/InventoryHostStaleness/BaseDropDown.js	87.50%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2194       +/-   ##
===========================================
- Coverage   76.08%   57.69%   -18.39%     
===========================================
  Files         193      193               
  Lines        5038     5203      +165     
  Branches     1779     1902      +123     
===========================================
- Hits         3833     3002      -831     
- Misses       1205     2201      +996

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gkarat · 2024-06-25T09:31:03Z

@adonispuente, I think we've got one merge conflict after the recent push to master. Can you please take a look?

mkholjuraev

LGTM! Conflicts seem to be minor. Thus approving. If you feel another eye is needed, feel free to ping

adonispuente · 2024-06-25T15:13:19Z

/retest

Victoremepunto · 2024-06-25T16:00:03Z

/retest

aptmac · 2024-06-25T20:03:40Z

Hi! I've been keeping tabs on this PR while working on something similar for the insights-runtimes-frontend repo. Just a couple of things I've come across:

I've noticed that the fec.config.js here is missing the custom proxy when running npm run start:mock, so the prism mock server isn't used.
I've also noticed (and something I'm looking into at the moment) is that trying to specify a port number isn't working when running a LOCAL_APPS setup. npm run start -- --port=8004 for example doesn't take the 8004 into consideration, and for me at least it starts up on port 8002.

adonispuente · 2024-06-25T20:20:03Z

@aptmac I took a look around some other applications and it seems that this is the case for the majority.
npm run start:mock isnt set up in the inventory repo itself, and the port issue is also in other apps as well. I think that has to be resolved in the package itself and then delivered to all the apps via package update or another means

aptmac · 2024-06-25T20:24:15Z

@aptmac I took a look around some other applications and it seems that this is the case for the majority. npm run start:mock isnt set up in the inventory repo itself, [..]

It used to be in the dev.webpack.config.js see: here, FWIW I've added it into the runtimes-frontend repo the same way it was in the old webpack and it's been working, see: https://github.com/RedHatInsights/insights-runtimes-frontend/pull/16/files#diff-d0f06d7cd724a6add60ee1bac8183344dc66faae9dac3ee6ee920f5b7ac3a88eR18

adonispuente · 2024-06-25T20:28:26Z

@aptmac thank you! Im not against it, but now that I see the other converted apps are ran the same way im thinking maybe we wanted to remove the mock option for some reason, or if there was just going to be a short period before the new set up can handle it 'directly'.
Nice fix though, im gonna ask around and see if theres a reason, but if not then I can add that in, or at least look into how to bake it into the package

aptmac · 2024-06-25T20:32:25Z

Was just snooping around the frontend-components repo and found RedHatInsights/frontend-components#2007, looks like that might address the LOCAL_APPS in the future, just a heads up!

* feat(RHINENG-7047): Upgrade inventory FEC config

ezr-ondrej · 2024-06-26T09:35:53Z

do I read it correctly image build for this have failed?

mkholjuraev · 2024-06-26T09:47:08Z

do I read it correctly image build for this have failed?

Yes, it seems the image is not built. We will have a look why

* feat(RHINENG-7047): Upgrade inventory FEC config

bastilian · 2024-06-26T11:44:30Z

src/components/InventoryGroups/Modals/ConfirmSystemsAddModal.js

@@ -1,7 +1,7 @@
 import { FormSpy, useFormApi } from '@data-driven-forms/react-form-renderer';
 import { Button, Flex, Icon } from '@patternfly/react-core';
 import ExclamationTriangleIcon from '@patternfly/react-icons/dist/js/icons/exclamation-triangle-icon';
-import warningColor from '@patternfly/react-tokens/dist/esm/global_warning_color_100';
+import { warningColor } from '@patternfly/react-tokens';


This should have been changed too, like the ones above. it is now raising an error when building:

adonispuente requested a review from a team as a code owner May 9, 2024 19:57

adonispuente marked this pull request as draft May 9, 2024 20:19

adonispuente force-pushed the refactor branch 2 times, most recently from c79b3d1 to d06d7bf Compare May 13, 2024 21:29

adonispuente marked this pull request as ready for review May 13, 2024 21:29

adonispuente changed the title ~~update components to pf5~~ feat(RHINENG-7074) : Update inventory fec config May 13, 2024