Fixed mods not loading from app_extra_mod_path
#3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RigsOfRods#3149 Problem was caused by myself in 74ed108 - apart from fixing the bug, I also made a cosmetic edit of resource group names - Instead of it being 'bundle $FULLPATH', I made it '{bundle $LOCALPATH}'. But I botched the code, causing exception "invalid string position" to be thrown. Solution: keep pretifying the resource group names, but account for all locations. I added a location-label to the name to avoid RG name clashes. * prepackaged mods, i.e. {bundle BIN:\content\simple2-terrain.zip} * extra mod path, i.e. {bundle EXTRA:\DI_SportsCar.zip} * mod dirs under user profile, i.e. {bundle USER:\mods\vehicles\Desperado.zip}
|
Able to successfully load into a terrain and vehicles from extramodpath now. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3149
Problem was caused by myself in 74ed108 - apart from fixing the bug, I also made a cosmetic edit of resource group names - Instead of it being 'bundle $FULLPATH', I made it '{bundle $LOCALPATH}'. But I botched the code, causing exception "invalid string position" to be thrown.
Solution: keep pretifying the resource group names, but account for all locations. I added a location-label to the name to avoid RG name clashes.