Added precision parameters for function that serializes BloomFilter from String#21
Open
juanpampliega wants to merge 1 commit intoRobinUS2:masterfrom
Open
Added precision parameters for function that serializes BloomFilter from String#21juanpampliega wants to merge 1 commit intoRobinUS2:masterfrom
juanpampliega wants to merge 1 commit intoRobinUS2:masterfrom
Conversation
Owner
|
Thanks for the PR, I'll merge this after #18 is done so we can have full integrated tests and make sure we don't introduce issues. |
Owner
|
@juanpampliega I have two small requests, could you please:
|
Owner
|
@juanpampliega do you see any chance you could incorporate those two changes above? Would be nice to get this PR in so you can use it as desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At Jampp we are using this plugin and writing the serialized BloomFilters as strings.
We use different expected numbers of inserts and false positive percentage than the defaults to construct the BloomFilters that are later serialized to string so I added new parameters to the
bloom_filter_from_stringso that converting them again to BloomFilters works correctly.