Skip to content

Added precision parameters for function that serializes BloomFilter from String #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juanpampliega wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added precision parameters for function that serializes BloomFilter from String #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/com/facebook/presto/bloomfilter/BloomFilterFromString.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,16 @@ public static void input(
bf.putAll(BloomFilter.newInstance(slice.getBytes()));
state.setBloomFilter(bf);
}

@InputFunction
public static void input(
BloomFilterState state,
@SqlType(VARCHAR) Slice slice,
@SqlType(StandardTypes.BIGINT) long expectedInsertions,
@SqlType(StandardTypes.DOUBLE) double falsePositivePercentage)
{
BloomFilter bf = getOrCreateBloomFilter(state, (int) expectedInsertions, falsePositivePercentage);
bf.putAll(BloomFilter.newInstance(slice.getBytes()));
state.setBloomFilter(bf);
}
}
3 changes: 3 additions & 0 deletions src/test/java/com/facebook/presto/bloomfilter/TestBloomFilterQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ public void testBloomFiltersTypeConversions()

// Test construction
assertQuery("WITH a AS (SELECT 'robin' AS uuid), b AS (SELECT bloom_filter(a.uuid) AS bf FROM a), c AS (SELECT to_string(b.bf) AS j FROM b), d AS (SELECT bloom_filter_from_string(c.j) AS bf2 FROM c) SELECT bloom_filter_contains(d.bf2, 'robin'), bloom_filter_contains(d.bf2, 'john') FROM d", "SELECT true, false");

// Test construction from string with precision
assertQuery("WITH a AS (SELECT 'robin' AS uuid), b AS (SELECT bloom_filter(a.uuid, 10, 0.05) AS bf FROM a), c AS (SELECT to_string(b.bf) AS j FROM b), d AS (SELECT bloom_filter_from_string(c.j, 10, 0.05) AS bf2 FROM c) SELECT bloom_filter_contains(d.bf2, 'robin'), bloom_filter_contains(d.bf2, 'john') FROM d", "SELECT true, false");
}

@Test
Expand Down