fix: input in confirm passcode not getting reset

[Rohit3523]

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

• Bug Fixes
  • Corrected passcode setup flow to clear the initial entry when restarting, preventing accidental clearing of the confirmation step.
  • Resolved a state handling typo that could cause inconsistent behavior during passcode entry.
  • Improves reliability and clarity when creating a new passcode.

[coderabbitai]

Caution

Review failed

The head commit changed during the review from 0d0c594 to 3203886.

Walkthrough

Fixes a state setter typo and updates the first-step behavior to clear the choose screen ref instead of the confirm screen ref in PasscodeChoose.tsx.

Changes

Cohort / File(s)	Summary
Passcode flow fixes app/containers/Passcode/PasscodeChoose.tsx	- Rename setPreviouPasscode → setPreviousPasscode and update its usage - In firstStep flow, call chooseRef?.current?.clearPasscode() instead of confirmRef?.current?.clearPasscode()

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor U as User
    participant PC as PasscodeChoose
    participant CH as chooseRef
    participant CF as confirmRef

    U->>PC: Enter passcode (first step)
    PC->>PC: setPreviousPasscode(p)
    Note right of PC: Store first entry for confirmation
    PC->>CH: clearPasscode()
    Note over CH,PC: Choose screen is reset for next input

    U->>PC: Enter passcode (confirm step)
    PC->>PC: Compare with previous
    alt match
        PC-->>U: Proceed
    else mismatch
        PC->>CH: clearPasscode()
        PC-->>U: Prompt retry
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• diegolmello
• OtavioStasiak

Poem

I nudge the keys with twitchy ears,
A typo hops away—no fears.
The choose ref clears, the flow aligned,
Two taps agree, in tidy kind.
Thump-thump! My paws approve the code—
Onward down the secure abode. 🐇🔐

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly identifies the primary change as fixing the issue where the confirm passcode input failed to reset, succinctly describing the bug and the intent to fix it in a single sentence. It is concise, specific, and uses a conventional “fix:” prefix to indicate the nature of the change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

iOS Build Available

Rocket.Chat Experimental 4.65.0.107462

[github-actions]

Android Build Available

Rocket.Chat Experimental 4.65.0.107461

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNSEn9luRZflwl-Cxlg3p9AE20MmKd9r2QsHDV_15tpnouPuIRlrYq2WMLpWm3pBTXcCLd2YEHZVJs7Cjjdf

[diegolmello]

Is this a regression or the bug was always there?
What's the behavior?

I'm missing CI jobs passing.

[Rohit3523]

CI is passing...

[Rohit3523]

Seems like a bug, so when we try to set a new screen lock and enter the password first time, in the confirm screen the password is prefilled and to continue we have to clear the password and enter it again to confirm