Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Issue #53: team-02 - Openrocket Integration #109

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

smkinney979
Copy link

@smkinney979 smkinney979 commented Aug 28, 2022

Hackathon PR for #53 from Team 02 Read the .ork

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly
  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally
  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

Enter text here...

What is the new behavior?

Feature to import parameters from OpenRocket .ork files. The file ork_testing.py will run the user through an example of how this new feature can be used. All feature functions are in utilities.py. There are a variety of comments through the functions and ork_testing.py that explain certain design decisions for a variety of the functions.

Note: ork_testing.py uses an amalgamation of .eng and drag curve files, so the trajectory generated by the flight is a little weird but is only for testing purposes.

Does this introduce a breaking change?

  • Yes
  • No

Other information

NA

Added a variety of utility functions to assist with parsing .ork files to create RocketPy simulations
@giovaniceotto
Copy link
Member

Wow!! This is awesome!!

@Gui-FernandesBR Gui-FernandesBR removed the request for review from giovaniceotto August 28, 2022 23:19
@Gui-FernandesBR Gui-FernandesBR changed the title Issue #53 Team 02 Issue #53: team-02 - Openrocket Integration Aug 28, 2022
@Gui-FernandesBR Gui-FernandesBR linked an issue Aug 28, 2022 that may be closed by this pull request
@giovaniceotto giovaniceotto self-requested a review August 28, 2022 23:49
@Gui-FernandesBR Gui-FernandesBR added Hard and removed Hard labels Sep 3, 2022
@giovaniceotto
Copy link
Member

@smkinney979, what a great job! Reading OpenRocket files is not easy, and converting them into RocketPy classes is even more of a challenge.

Thanks for submitting a working example, even if not complete (such as the missing motor).

I can see you worked quite hard to get this working and thus deserve a lot of points. Unfortunately, since the complete task was not satisfied, I cannot award you 100% score for this hard problem. But I can gladly give you the points equivalent to a medium challenge.

I am sure with a bit more time we can get this complete and ready to ship with the next version of RocketPy! I expect many more amazing contributions from you.

@giovaniceotto giovaniceotto added 25 points Medium challenges! team-02 extra_points Exceptionally ingenious solutions labels Sep 3, 2022
@Gui-FernandesBR
Copy link
Member

May recieve an extra 20% points since it was the onlly team solving this challege

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
25 points Medium challenges! extra_points Exceptionally ingenious solutions team-02
Projects
Development

Successfully merging this pull request may close these issues.

Read the .ork
3 participants