Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update texture podspec to 3.0 #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeffersonsetiawan
Copy link

Texture just released version 3.0 yesterday, so need to update the podspec

@jeffersonsetiawan
Copy link
Author

Hi @GeekTree0101 , do you mind reviewing this PR to support Texture 3? 🙏🏻

s.dependency 'Texture', '~> 2.7'
s.dependency 'Texture', '~> 3.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RxCocoa-Texture doesn't needs define minimum version 3.0 :]
Plz podspec rollback to min 2.7 & recommend to update Example/Podfile Texture 3.0 :]

use_frameworks!

target 'RxCocoa-Texture_Example' do
  pod 'RxCocoa-Texture', :path => '../'
  pod 'RxAlamofire'

  target 'RxCocoa-Texture_Tests' do
    inherit! :search_paths
    pod 'Texture', '3.0' // <---- HERE
    pod 'RxTest'
    pod 'RxBlocking'
    pod 'Quick'
    pod 'Nimble'
  end
end

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh just know about that ahhaha, should I revert the version as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried rollback the min version, and I got this error

[!] CocoaPods could not find compatible versions for pod "Texture":
  In Podfile:
    RxCocoa-Texture (from `../`) was resolved to 3.1.0, which depends on
      Texture (~> 2.7)

    Texture (= 3.0)

Specs satisfying the `Texture (= 3.0), Texture (~> 2.7)` dependency were found, but they required a higher minimum deployment target.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to remove pod lock on your local enviroment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-07-20 at 17 54 59

I've removed it but still showing the same error

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about replace to 3.0.0-rc2 ?

@GeekTree0101 GeekTree0101 self-assigned this Jul 20, 2020
@GeekTree0101 GeekTree0101 added the good first issue Good for newcomers label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants