Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update texture podspec to 3.0 #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Example/RxCocoa-Texture/RepositoryViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ import AsyncDisplayKit
import RxSwift
import RxCocoa

class RepositoryViewController: ASViewController<ASTableNode> {
class RepositoryViewController: ASDKViewController<ASTableNode> {

private var items: [RepositoryViewModel2] = []
private var context = ASBatchContext()

let disposeBag = DisposeBag()

init() {
override init() {
let tableNode = ASTableNode(style: .plain)
tableNode.backgroundColor = .white
tableNode.automaticallyManagesSubnodes = true
Expand Down
4 changes: 2 additions & 2 deletions RxCocoa-Texture.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'RxCocoa-Texture'
s.version = '3.1.0'
s.version = '3.2.0'
s.summary = 'RxCocoa Extension Library for Texture'

s.description = 'This library is built on Texture with RxCocoa, RxCocoa is a framework that helps make Cocoa APIs used in iOS and OS X easier to use with reactive techniques.'
Expand All @@ -16,5 +16,5 @@ Pod::Spec.new do |s|

s.dependency 'RxSwift', '~> 5.0'
s.dependency 'RxCocoa', '~> 5.0'
s.dependency 'Texture', '~> 2.7'
s.dependency 'Texture', '~> 3.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RxCocoa-Texture doesn't needs define minimum version 3.0 :]
Plz podspec rollback to min 2.7 & recommend to update Example/Podfile Texture 3.0 :]

use_frameworks!

target 'RxCocoa-Texture_Example' do
  pod 'RxCocoa-Texture', :path => '../'
  pod 'RxAlamofire'

  target 'RxCocoa-Texture_Tests' do
    inherit! :search_paths
    pod 'Texture', '3.0' // <---- HERE
    pod 'RxTest'
    pod 'RxBlocking'
    pod 'Quick'
    pod 'Nimble'
  end
end

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh just know about that ahhaha, should I revert the version as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried rollback the min version, and I got this error

[!] CocoaPods could not find compatible versions for pod "Texture":
  In Podfile:
    RxCocoa-Texture (from `../`) was resolved to 3.1.0, which depends on
      Texture (~> 2.7)

    Texture (= 3.0)

Specs satisfying the `Texture (= 3.0), Texture (~> 2.7)` dependency were found, but they required a higher minimum deployment target.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to remove pod lock on your local enviroment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-07-20 at 17 54 59

I've removed it but still showing the same error

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about replace to 3.0.0-rc2 ?

end