-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default mrc permissive to false, try to autorecover, remove userfacing 'permissive' argument #140
change default mrc permissive to false, try to autorecover, remove userfacing 'permissive' argument #140
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against a444948 |
@McHaillet Did you have some example failing MRCs as were mentioned in #35 ? |
…tom-template-matching-gpu into change_mrc_permission_to_strict
…warpper to try to autorecover
@McHaillet It took a while, but this is ready for a round of review 😄 Feel free to throw some other files at it to see if you like/dislike the behavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very solid too me, really nothing to too comments 👍
Don't really have any more examples of corrupt mrcs, so nothing to further test from my side. Feel free to merge!
closes #39
Done:
permissive
fromread_mrc
andread_mrc_meta_data