Open
Conversation
ZarMarathon
approved these changes
Jun 3, 2021
Collaborator
ZarMarathon
left a comment
ZarMarathon
left a comment
There was a problem hiding this comment.
В целом хорошо, комментарии оставил в коде) ты молодец)
Как тебе уроки? все посмотрел? что-то новое нашел?
| const player1 = { | ||
| name: 'Silver', | ||
| hp: 100, | ||
| img: 'img' , |
Collaborator
There was a problem hiding this comment.
Почему бы в img сразу не передать src картинки?
| $img.src = 'http://reactmarathon-api.herokuapp.com/assets/scorpion.gif'; | ||
| $player1.appendChild($img); No newline at end of file | ||
| // appends | ||
| const $arenas = document.querySelector('.arenas'); |
Collaborator
There was a problem hiding this comment.
Лучше вынести на самый верх, вообще старайся объявлять переменные вначале документа/функции, что бы было более читаемо какие переменные будут использоваться дальше)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ДЗ сделал, вопросов в принципе нету. Только 1 вопрос, что за задача со звездочкой ? )