Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 50 additions & 10 deletions main.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,56 @@
const $player1 = document.createElement('div');
$player1.classList.add('player1');
const player1 = {
name: 'Silver',
hp: 100,
img: 'img' ,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему бы в img сразу не передать src картинки?

weapon: ['ak47', 'kunai', 'sword', 'axe'],
attack: function () {
console.log(player1.name + ' Fight....');
}
};
const player2 = {
name: 'Bronze',
hp: 100,
img: 'img',
weapon: ['ak47', 'kunai', 'sword', 'axe'],
attack: function () {
console.log(player2.name + ' Fight....');
}
};
function createPlayer(player, name, hp, img) {
// create elements
const $player1 = document.createElement('div');
$player1.classList.add(player);

const $p = document.createElement('p');
$p.innerText = 'Scorpion';
const $progressbar = document.createElement('div');
$progressbar.classList.add('progressbar');

$player1.appendChild($p);
const $character = document.createElement('div');
$character.classList.add('character');

const $root = document.querySelector('.root');
const $life = document.createElement('div');
$life.classList.add('life');

$root.appendChild($player1);
const $name = document.createElement('div');
$name.innerText = name;
$name.classList.add('name');

const $img = document.createElement ('img');
const $img = document.createElement('img');
$img.src = img;

$img.src = 'http://reactmarathon-api.herokuapp.com/assets/scorpion.gif';
$player1.appendChild($img);
// appends
const $arenas = document.querySelector('.arenas');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше вынести на самый верх, вообще старайся объявлять переменные вначале документа/функции, что бы было более читаемо какие переменные будут использоваться дальше)

$arenas.appendChild($player1);
$player1.appendChild($progressbar);
$player1.appendChild($character);
$character.appendChild($img);
$progressbar.appendChild($life);
$progressbar.appendChild($name);

// style
$life.style.width = hp + '%';


return createPlayer;
};
createPlayer('player1', 'Bronze', 80, 'http://reactmarathon-api.herokuapp.com/assets/scorpion.gif');
createPlayer('player2', 'Silver', 50, 'http://reactmarathon-api.herokuapp.com/assets/kitana.gif');