fixes #295 - handle Duplicate error while creating aap job labels #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobCallahan
approved these changes
Jun 16, 2024
ogajduse
approved these changes
Jun 17, 2024
|
@rplevka is this ready to merge? |
|
@JacobCallahan yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to
POSTto job labels straight away and catch eventualDuplicate400response.in such case, retrieve the label id using the
GETmethod and carry on.2 consecutive broker checkout commands with passing the same label should be enough to test this.
the first one creates the label on AAP, while the other one hits the
400and handles it.As a result, both resulting AAP jobs have the same job label attached and both broker commands finish successfully.