Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #295 - handle Duplicate error while creating aap job labels #296

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fixes #295 - handle Duplicate error while creating aap job labels #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions broker/providers/ansible_tower.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,15 +457,21 @@ def _resolve_labels(self, labels, target):
label_ids = []
for label in labels:
label_expanded = f"{label}={labels[label]}" if labels[label] else label
if result := self.v2.labels.get(name=label_expanded).results:
label_ids.append(result[0].id)
else:
# label does not exist yet, creating
try:
result = self.v2.labels.post(
{"name": label_expanded, "organization": target.summary_fields.organization.id}
)
if result:
label_ids.append(result.id)
except awxkit.exceptions.Duplicate:
logger.debug(f"Provider label {label_expanded} already exists on AAP instance")
if result := self.v2.labels.get(name=label_expanded).results:
logger.debug(f"Provider label {label_expanded} retrieved successfully")
label_ids.append(result[0].id)
else:
logger.warning(
f"Provider label {label_expanded} not found on AAP despite AAP returning 400: Duplicate while trying to create it"
)
return label_ids

@cached_property
Expand Down