Fix validation: validate IPv6 proxy URL only when IS_IPV6 is set to True #15413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogajduse
added
Easy Fix :)
jyejare
approved these changes
Jun 14, 2024
rmynar
approved these changes
Jun 14, 2024
jyejare
removed
6.13.z
|
@ogajduse I just backported Ipv6 to 6.15 and it likely won't go beyond that. If needed we can do cherry-pick later. |
lpramuk
approved these changes
Jun 17, 2024
|
Cherrypicking this PR should follow cherrypicking of previous validators fixes - #15277 |
ogajduse
added a commit
to ogajduse/robottelo
that referenced
this pull request
Jun 17, 2024
…rue (SatelliteQE#15413) (cherry picked from commit 90ffb9b)
ogajduse
added a commit
to ogajduse/robottelo
that referenced
this pull request
Jun 17, 2024
…rue (SatelliteQE#15413) (cherry picked from commit 90ffb9b)
This was referenced Jun 17, 2024
lpramuk
pushed a commit
that referenced
this pull request
Jun 17, 2024
… set to True (#15423) Fix validation: validate IPv6 proxy URL only when IS_IPV6 is set to True (#15413) (cherry picked from commit 90ffb9b) Co-authored-by: Ondřej Gajdušek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Using latest robottelo, including the IPv6-related changes, I am running into
This error is caused by a validator that enforces string type, but it is setting the value to None itself. :meow_shrugs:
Solution
Utilize conditional validation - validate the IPv6 proxy URL setting only when IS_IPV6 is set to True
https://www.dynaconf.com/validation/#conditional-validation
Related Issues
This should be fixed before #15289 goes in