Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last OrdinaryDiffEq mention #1150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TorkelE
Copy link
Member

@TorkelE TorkelE commented Dec 18, 2024

Was going to finish this one off #1096, but @vyudu already did. Did the one case remaining in a docstring though. Also, there is this from the JumpInputs docstring:

using Catalyst, OrdinaryDiffEq, JumpProcesses, Plots
rn = @reaction_network begin
    k*(1 + sin(t)), 0 --> A
end
jinput = JumpInputs(rn, [:A => 0], (0.0, 10.0), [:k => .5])
@assert jinput.prob isa ODEProblem
jprob = JumpProblem(jinput)
sol = solve(jprob, Tsit5())
plot(sol, idxs = :A)

rn = @reaction_network begin
    k, 0 --> A
end
jinput = JumpInputs(rn, [:A => 0], (0.0, 10.0), [:k => .5])
@assert jinput.prob isa DiscreteProblem
jprob = JumpProblem(jinput)
sol = solve(jprob)
plot(sol, idxs = :A)

Could this be changed from OrdinaryDiffEq to OrdinaryDiffEqTsit5 @isaacsas?

@isaacsas
Copy link
Member

@TorkelE yes, that could probably be changed. Trying running it and if it works go ahead and update it too.

@isaacsas isaacsas closed this Dec 20, 2024
@isaacsas isaacsas reopened this Dec 20, 2024
@isaacsas
Copy link
Member

Let's see if tests are still failing.

@isaacsas isaacsas closed this Dec 28, 2024
@isaacsas isaacsas reopened this Dec 28, 2024
@@ -43,7 +43,7 @@ u0 = [:X => rand(5,5)]
tspan = (0.0, 1.0)
ps = [:p => 1.0, :d => 0.5, :D => 0.1]
oprob = ODEProblem(lrs, u0, tspan, ps)
osol = solve(oprob)
osol = solve(oprob, Tsit5())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure Tsit5 is a good recommendation for a spatial system? I would think you'd want an implicit solver often?

@TorkelE
Copy link
Member Author

TorkelE commented Dec 28, 2024

Good point actually. Not sure at all to be honest. Would the sensible be to just do some tests with various solvers and see what is fastest?

@isaacsas
Copy link
Member

Good point actually. Not sure at all to be honest. Would the sensible be to just do some tests with various solvers and see what is fastest?

Yes, I'd think so.

@ChrisRackauckas
Copy link
Member

Or at least ROCK

@isaacsas isaacsas closed this Dec 28, 2024
@isaacsas isaacsas reopened this Dec 28, 2024
@isaacsas
Copy link
Member

I think if you update to master this should hopefully now build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants