-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove last OrdinaryDiffEq mention #1150
base: master
Are you sure you want to change the base?
Conversation
@TorkelE yes, that could probably be changed. Trying running it and if it works go ahead and update it too. |
Let's see if tests are still failing. |
@@ -43,7 +43,7 @@ u0 = [:X => rand(5,5)] | |||
tspan = (0.0, 1.0) | |||
ps = [:p => 1.0, :d => 0.5, :D => 0.1] | |||
oprob = ODEProblem(lrs, u0, tspan, ps) | |||
osol = solve(oprob) | |||
osol = solve(oprob, Tsit5()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure Tsit5 is a good recommendation for a spatial system? I would think you'd want an implicit solver often?
Good point actually. Not sure at all to be honest. Would the sensible be to just do some tests with various solvers and see what is fastest? |
Yes, I'd think so. |
Or at least ROCK |
I think if you update to master this should hopefully now build. |
Was going to finish this one off #1096, but @vyudu already did. Did the one case remaining in a docstring though. Also, there is this from the
JumpInputs
docstring:Could this be changed from
OrdinaryDiffEq
toOrdinaryDiffEqTsit5
@isaacsas?