Numpy 2 testing #427
Draft
Numpy 2 testing #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
5 tasks
|
NOTE: This might couple to #443 |
pp-mo
requested review from
ukmo-ccbunney and
ESadek-MO
and removed request for
bjlittle,
ukmo-ccbunney and
ESadek-MO
Note that PyPI doesn't support repodata patching, like in conda-forge. That means cf-units build with numpy<2 will be installable in numpy>=2 envs unless the user pins it! Changes like https://github.com/SciTools/cf-units/pull/427/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 would help ameliorate that if a new release with these changes are out soon. Another action would be a post release of the current one with the numpy<2 pin in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR adapts the code for numpy 2.0. I'm building on top of #313 b/c this one should be merged after that one.
Note that I did not add numpy 2.0 to the test matrix yet. The test matrix here is quite complex with automated conda-lock, tox, etc. It is quite hard to contribute to it!